Use Node 20 #1
Open
Use Node 20 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update runtime to Node v20, including types package, as well as Node version used in Workflow.
We were seeing an issue running the main workflow after the upgrade to Node v20. The issue seems to match this one here: cevek/ttypescript#150
This fixes warnings that show up when running the workflow.
Update the examples in the README to use Node v20, as well as to use more recent versions (via tag) of the action itself.
AndrewADev
force-pushed
the
chore/node-v20
branch
from
b8f5ccb
to
d4079c6
Compare
|
Hey @jpribyl , do you think you'd be able to take a look at this? |
Totally! yeah I'll try to carve out some time this week for it. Thanks for the PR! |
2 tasks
|
I've also got a PR in action-docker-layer-caching, but that depends on this PR. Specifically I think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to switch to Node 20, as 16 is no longer supported and GitHub is deprecating Node 16 actions.
Given the deprecation, these changes make a hard cut, and drop support for 16.
Also included are updates to the actions used internally, so that they are on versions using Node 20 as well
(Warnings when running the workflow with the previous versions)
Note that this upgrade should help unblock a fix for a similar issue for the
action-docker-layer-cachingaction, which uses this action in the workflows.CI checks passing on my fork:
