Do not initialize spec values with undefined #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemalettin-work
force-pushed
the
master
branch
from
e7150b9
to
207aea7
Compare
|
thanks for the PR, i'd need some context for why this behavior should be changed and tests as well |
|
oops sorry i didn't see the linked issue 👍 do still need tests tho |
jquense
reviewed
Dec 13, 2020
cemalettin-work
force-pushed
the
master
branch
from
207aea7
to
c5a4aaa
Compare
Concatting schemas can overwrite previous non-undefined values with undefined
cemalettin-work
force-pushed
the
master
branch
from
c5a4aaa
to
08a86c5
Compare
cemalettin-work
changed the title
jquense
approved these changes
Dec 13, 2020
|
thanks! |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise spreading spec values like previously would overwrite the base schema spec values with undefined.
Closes #1160.