-
Notifications
You must be signed in to change notification settings - Fork 160
Replace PointerMap with polyfill for regular Map #189
Conversation
Just signed the CLA, not sure why the status hasn't updated. |
I'm not sure what this actually gets us. We're still not using the standard |
In fact, won't this just throw errors in any browser that has |
This isn't using the standard Map API? What's different? |
|
Right - so the polyfill should implement a getter for |
7b87104
to
b8578a5
Compare
|
Fixed tests (I think, I'm not familiar with intern). |
1349161
to
46b3172
Compare
Derp, changing how existing Map() is looked up now. |
I'm going to go ahead and remove the part of the |
Okay, the only errors in the build now are the ones that are present in the current |
So, since this is only needed to map pointers with (low) integer IDs for keys, why not just use a sparse Array to polyfill the Map? |
We went with the sparse array implementation from gh-190. |
Ideally, this polyfill would be left out of this project altogether (to be handled by a dedicated polyfill like CoreJS), but that can be done later.