This repository has been archived by the owner on Feb 11, 2021. It is now read-only.
Replace PointerMap with potentially-sparse-array-based Map polyfill #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var USE_MAP = window.Map && window.Map.prototype.forEach; | ||
| var POINTERS_FN = function() { return this.size; }; | ||
| var USE_MAP = window.Map && window.Map.prototype.forEach && | ||
| !Object.getOwnPropertyDescriptor(Map.prototype,'size').value; |
There was a problem hiding this comment.
What is this guarding against?
There was a problem hiding this comment.
There was a problem hiding this comment.
That's silly, why would we care about something that was fixed almost three years ago? Remove this.
There was a problem hiding this comment.
That's silly, why would we care about something that was fixed almost three years ago?
Why check window.Map.prototype.forEach then?
|
@stuartpb Are you able to attend our meeting today? It's on IRC at noon ET (#jquery-meeting on freenode). |
|
@scottgonzalez Sure, I can stay up for a few more hours. |
|
Is there a reason not to just use an object instead of an array? |
narqo
pushed a commit
to bem/bem-core
that referenced
this pull request
Jul 7, 2015
…y in IE Edge Use native `PointerEvent` if supported. fix #1066 Optimise PointerMap class: use native Map class if supported (port of jquery-archive/PEP#190).
narqo
pushed a commit
to bem/bem-core
that referenced
this pull request
Jul 7, 2015
…y in IE Edge Use native `PointerEvent` if supported. fix #1066 Optimise PointerMap class: use native Map class if supported (port of jquery-archive/PEP#190).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to gh-189