Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.widget: Improves Performance of cleanData-Method. Fix for http://bugs.jqueryui.com/ticket/9546 #1289

Closed
wants to merge 1 commit into from

Conversation

felvhage
Copy link
Contributor

The cleanData-Method triggered "remove" on all elements in the tree.
After the fix the remove-handler will only be triggered if there is at least
one event bound to the element. Doing so increases performance significantly.
performance-comparison http://jsfiddle.net/felvhage/r7buw/

Fixes #9546

The cleanData-Method triggered "remove" on all elements in the tree.
After the fix the remove-handler will only be triggered if there is at least
one event bound to the element. Doing so increases performance significantly.
performance-comparison http://jsfiddle.net/felvhage/r7buw/

Fixes #9546
@scottgonzalez
Copy link
Member

Thanks. Please complete the following tasks (covered by our contributing guidelines):

You can probably save even more time by specifically checking for a remove property.

@scottgonzalez
Copy link
Member

Replaced by #1291.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants