ui.widget: Improves Performance of cleanData-Method (Issue #9546) #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cleanData-Method triggered "remove" on all elements in the tree. After the fix the remove-handler will only be triggered if it exists. Doing so increases performance significantly. See performance-comparison http://jsfiddle.net/r7buw/17/ Fixes #9546
| $( elem ).triggerHandler( "remove" ); | ||
| // Only trigger remove when necessary to save time | ||
| var events = $._data( elem, "events" ); | ||
| if( events !== undefined && events.remove ){ |
There was a problem hiding this comment.
if ( events && events.remove ) {
|
Thanks. I'll fix the style issues when I merge this. |
|
You signed the CLA with a different email address than you have in your git config. Which email address do you want to use? |
| @@ -27,7 +27,11 @@ $.cleanData = (function( orig ) { | |||
| return function( elems ) { | |||
| for ( var i = 0, elem; (elem = elems[i]) != null; i++ ) { | |||
| try { | |||
| $( elem ).triggerHandler( "remove" ); | |||
| // Only trigger remove when necessary to save time | |||
| var events = $._data( elem, "events" ); | |||
There was a problem hiding this comment.
Multiple var statements aren't allowed, and variables should never be declared inside a loop.
|
In the future, please make sure to run the tests. |
|
Sorry about the style-errors. I will have have a look at grunt/jshint.... |
|
I'll give it another try. |
Don't worry about it. I've got it all fixed locally, about to merge... |
|
Ok 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #9546
It increases performance of cleanData as demonstrated here: http://jsfiddle.net/r7buw/17/
(Pull Request meta: second try)