Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown-insert-gfm-foldable-block #596

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

psibi
Copy link
Contributor

@psibi psibi commented Feb 6, 2021

This can be used for adding a collapsible content. Works in both
github and gitlab from my testing.

More details here: #595

Description

Both github and gitlab support the feature where you can use to fold a content: https://stackoverflow.com/questions/52214187/how-can-i-fold-content-in-github-markdown

Related Issue

#595

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

Sorry, something went wrong.

psibi added 3 commits February 6, 2021 15:01
This can be used for adding a collapsible content. Works in both
github and gitlab from my teseting.

More details here: jrblevin#595
@psibi
Copy link
Contributor Author

psibi commented Feb 10, 2021

@syohex I see that you are one of the active maintainers of the project. You have any comments/feedback on the PR ?

@syohex syohex mentioned this pull request Feb 10, 2021
6 tasks
@syohex
Copy link
Collaborator

syohex commented Feb 10, 2021

@psibi I have improve your PR at #598. Please check it.

syohex added a commit that referenced this pull request Feb 10, 2021
@syohex syohex merged commit 94ea3c6 into jrblevin:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants