Improve #596 #598
Merged
Improve #596 #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used for adding a collapsible content. Works in both github and gitlab from my teseting. More details here: #595
- Fix wrong style - remove 'gfm' keyword from function name. Because it is not gfm specific feature - Remove needless code
9 tasks
|
The changes LGTM. Thank you! |
psibi
reviewed
Feb 10, 2021
| @@ -12,6 +12,7 @@ | |||
| `markdown-disable-tooltip-prompt`. | |||
| - Introduce `markdown-ordered-list-enumeration` variable [GH-587][] | |||
| - Search wiki link under project | |||
| - Add `markdown-insert-gfm-foldable-block` function [GH-596][] | |||
There was a problem hiding this comment.
Missed while reviewing the first time: I guess it shouldn't have gfm since you renamed it ?
There was a problem hiding this comment.
sorry I'll fix it later
There was a problem hiding this comment.
No worries. :-) Thanks for adding the test case and making the code better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve #596
Related Issue
#595, #596 CC: @psibi
Type of Change
Checklist
make test).