Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace callbacks with promise based api #58

Open
TrySound opened this issue Jul 1, 2020 · 1 comment
Open

Replace callbacks with promise based api #58

TrySound opened this issue Jul 1, 2020 · 1 comment

Comments

@TrySound
Copy link
Contributor

TrySound commented Jul 1, 2020 •
edited
Loading

We already use promises internally. Perhaps it would be a good step forward to provide promise based api instead of old callback style. The code may be simplified as well.
TrySound added a commit to TrySound/web-resource-inliner that referenced this issue Jul 1, 2020
@TrySound
Refactor async parallel with Promise.all
6090102 
Ref jrit#58

In this diff I refactored as small as possible part of code to replace
`async.parallel` with `Promise.all` and do not introduce any breaking
changes.

Further refactoring can be made in separate PR.
@TrySound TrySound mentioned this issue Jul 1, 2020
Merged
TrySound added a commit to TrySound/web-resource-inliner that referenced this issue Jul 1, 2020
@TrySound
Refactor async parallel with Promise.all
10caaa3 
Ref jrit#58

In this diff I refactored as small as possible part of code to replace
`async.parallel` with `Promise.all` and do not introduce any breaking
changes.

Further refactoring can be made in separate PR.
@jrit
Copy link
Owner

jrit commented Sep 29, 2020

yeah, I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrit @TrySound