Refactor async parallel with Promise.all #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jrit |
|
My interest here is mjml which depends on juice so I will try to simplify juice as well after finishing with this package. |
|
can you resolve the conflicts on this one? I think I can merge and release on this PR without anything breaking before merging the one that requires node 10 and will be a major version. Correct? |
Ref jrit#58 In this diff I refactored as small as possible part of code to replace `async.parallel` with `Promise.all` and do not introduce any breaking changes. Further refactoring can be made in separate PR.
|
Right, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #58
In this diff I refactored as small as possible part of code to replace
async.parallelwithPromise.alland do not introduce any breakingchanges.
Further refactoring can be made in separate PR.