-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[general] Write overwriting files in terms of .exists() #1422
Conversation
aafa4aa
to
e74f29b
Compare
Btw found it very confusing that this change was not in the changelog! |
I noticed the change where With this new behavior, how would you recommend handling such cases when Thanks in advance for the clarification! |
@CorentinGoodays looks like the behaviour should be walked back in django-storages. See: |
Indeed, the intent is to walk back the behavior which is why no new version has been released. If someone wants to submit a patch that fixes this for all backends and doesn't introduce a security vulnerability (following Django's lead most likely) then I would happily merge. |
Reverts #11560 New version of django-storages introduced behavior that breaks `exists()` when `allow_overwrite` is True. This is going to be reverted, but there's no release with the revert yet. See this PR for more info: jschneier/django-storages#1422 For now we can revert the library updates from yesterday (esp bc they didn't fix the problem we were trying to fix at the time), and when django-storages gets an update we can try again.
Follow upstream and write the file overwriting handling in terms of
exists()
.Reference: django/django@0b33a3a#diff-63fca472a0ca8c04505cb4ec9c132663ac71fc964110afc8ae9218416f37821cR195-R202