chore(project): bump django-storages to 1.14.4 #11560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Becuase * We are migrating to the new GCPV2 infrastructure * It uses 'GKE Workloads' to manage permissions * Displaying screenshots in the UI requires generating 'signed urls' * The old versions of django-storages and google-cloud-storages don't support signing urls in GKE Workloads This commit * Bumps to the latest django-storages and google-cloud-storages * Hopefully this allows us to generate signed urls with GKE Workloads fixes #11559
mikewilli
approved these changes
Oct 17, 2024
mikewilli
added a commit
that referenced
this pull request
Oct 18, 2024
This reverts commit 7ad146c.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
Reverts #11560 New version of django-storages introduced behavior that breaks `exists()` when `allow_overwrite` is True. This is going to be reverted, but there's no release with the revert yet. See this PR for more info: jschneier/django-storages#1422 For now we can revert the library updates from yesterday (esp bc they didn't fix the problem we were trying to fix at the time), and when django-storages gets an update we can try again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #11559