requireSpaceBeforeKeywords: correct keywords check

Fixes #2135
jscs-dev · Feb 15, 2016 · 594a4ee · 594a4ee
1 parent c695048
commit 594a4ee
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lib/rules/require-space-before-keywords.js b/lib/rules/require-space-before-keywords.js
@@ -55,9 +55,11 @@ module.exports.prototype = {
             excludedKeywords = keywords.allExcept;
         }
 
-        keywords = defaultKeywords.filter(function(keyword) {
-            return (excludedKeywords.indexOf(keyword) === -1);
-        });
+        if (!Array.isArray(keywords)) {
+            keywords = defaultKeywords.filter(function(keyword) {
+                return (excludedKeywords.indexOf(keyword) === -1);
+            });
+        }
 
         this._keywords = keywords;
     },

diff --git a/test/specs/rules/require-space-before-keywords.js b/test/specs/rules/require-space-before-keywords.js
@@ -121,4 +121,12 @@ describe('rules/require-space-before-keywords', function() {
         expect(errors).to.have.one.validation.error.from('requireSpaceBeforeKeywords');
         expect(errors.explainError(error)).to.have.string('Missing space before "function" keyword');
     });
+
+    it('should ignore keywords that is not mentioned in the config list (#2135)', function() {
+        checker.configure({ requireSpaceBeforeKeywords: [] });
+
+        expect(
+            checker.checkString('if (typeof value !== "function") {}')
+        ).to.have.no.errors();
+    });
 });