v2.10.0 - requireSpaceBeforeKeywords reports on a keyword not in its list

[ljharb]

In my config file, I have:

       "requireSpaceBeforeKeywords": [
         "do",
         "for",
         "if",
         "else",
         "switch",
         "case",
         "try",
         "catch",
         "finally",
         "while",
         "with",
         "return"
       ],

However, upon upgrading to v2.10.0, I get output like:

Missing space before "typeof" keyword at index.js :
    32 |module.exports = function isCallable(value) {
    33 | if (!value) { return false; }
    34 | if (typeof value !== 'function' && typeof value !== 'object') { return false; }
-------------^
    35 | if (hasToStringTag) { return tryFunctionObject(value); }
    36 | if (isES6ClassFn(value)) { return false; }

Missing space before "typeof" keyword at test.js :
    96 |test('Typed Arrays', function (st) {
    97 | forEach(typedArrayNames, function (typedArray) {
    98 |  if (typeof global[typedArray] !== 'undefined') {
--------------^
    99 |   st.ok(isCallable(global[typedArray]), typedArray + ' is callable');
   100 |  }

Note that "typeof" is not in my array of things I want a space before, and this was not an error in v2.9.x.

[hzoo]

Ok that is really weird.. I haven't checked all the commits so will look through. @markelog

[ljharb]

I do note in the changelog that this rule was changed - perhaps it's an unintended consequence?

[hzoo]

Yeah definitely needs a fix.

[hzoo]

Ok probably #2063

[ljharb]

commented on the line responsible, hopefully the fix includes a regression test ;-)

[ljharb]

Thanks, any idea how long before a v2.10.1?

[hzoo]

Was busy, I think we were making sure it was correct

[ljharb]

Sounds good, just looking for a timeline :-) thanks for the fast responses everyone!