Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jscs@2.10.0 breaks build 🚨 #7

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link

Hello 👋

🚨🚨🚨

jscs just published its new version 2.10.0, which is covered by your current version range. After updating it in your project the build went from success to failure.

This means your software is now malfunctioning, because of this update. Use this branch to work on adaptions and fixes.

Happy fixing and merging 🌴


GitHub Release

Version 2.10.0 (2016-02-15):

Happy Presidents Day!

In this release, it's just some additional rules to update to the airbnb preset, new rules, and fixes.

Preset Changes

  • Add maximumLineLength to the airbnb preset (reference) (Oleg Gaidarenko)
  • Add disallowSpacesInsideTemplateStringPlaceholders to the airbnb preset (not explicit but used in examples) (Oleg Gaidarenko)
  • Add disallowNewlineBeforeBlockStatements rule to the mdcs preset (reference) (Mauricio Massaia)

New Rules

disallowSpacesInsideTemplateStringPlaceholders

(ikokostya)

Disallows spaces before and after curly brace inside template string placeholders.

// usage in config
"disallowSpacesInsideTemplateStringPlaceholders": true
// Valid
`Hello ${name}!`
// Invalid
`Hello ${ name}!`
`Hello ${name }!`
`Hello ${ name }!`

requireImportsAlphabetized (Ray Hammond)

Requires imports to be alphabetized

// usage in config
"requireImportAlphabetized": true
// Valid
import a from 'a';
import c from 'c';
import z from 'z';
// Invalid
import a from 'a';
import z from 'z';
import c from 'c';

Rule Updates

  • requireSpaceBeforeKeywords: skip function by default (gpiress)

Bug Fixes

  • requireNumericLiterals: miss if first argument is an Identifier (Robert Jackson)
  • disallowSpacesInsideTemplateStringPlaceholders: skip the edge case (Oleg Gaidarenko)
  • requirePaddingNewLinesBeforeExport: exclude if only statement in block (Brian Schemp)
  • maximumLineLength: some nodes might contain null values (Oleg Gaidarenko)

Docs

  • Correct date in the changelog (Oleg Gaidarenko)
  • Various rule corrections (Christopher Cook)

The new version differs by 16 commits .

  • 3e918af 2.10.0
  • 9bb126b Misc: add 2.10.0 changelog
  • 9cc27b9 requireNumericLiterals: miss if first argument is an Identifier
  • 7d30671 Preset: add maximumLineLength to airbnb preset
  • 972769d Misc: code style fixes
  • 222cccf disallowSpacesInsideTemplateStringPlaceholders: skip the edge case
  • f8590fd Preset: add disallowSpacesInsideTemplateStringPlaceholders to airbnb
  • 0e00ce8 Docs: correct date in the changelog
  • c19442a New Rule: disallowSpacesInsideTemplateStringPlaceholders
  • 9b59f46 Preset: add disallowNewlineBeforeBlockStatements rule
  • 998eb2d Misc: make linters happy
  • ee7577d Docs: various rule corrections
  • 488ec0d requirePaddingNewLinesBeforeExport: exclude if only statement in block
  • c9fab40 requireSpaceBeforeKeywords: added a new rule option
  • 17daa29 New rule: require-imports-alphabetized

There are 16 commits in total. See the full diff.


This pull request was created by greenkeeper.io.
It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡

@ljharb
Copy link
Owner

ljharb commented Feb 15, 2016

Blocked on jscs-dev/node-jscs#2135

@ljharb
Copy link
Owner

ljharb commented Feb 16, 2016

Done in 5320c76

@ljharb ljharb closed this Feb 16, 2016
@ljharb ljharb deleted the greenkeeper-jscs-2.10.0 branch February 16, 2016 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants