Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Appveyor: fixup tests and check work on win #1136

Closed
qfox opened this issue Mar 4, 2015 · 5 comments
Closed

Appveyor: fixup tests and check work on win #1136

qfox opened this issue Mar 4, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@qfox
Copy link
Member

qfox commented Mar 4, 2015

Ref #1126 (comment)
Ref nodejs/node#1068

@qfox qfox self-assigned this Mar 4, 2015
@qfox qfox added the bug label Mar 4, 2015
@qfox qfox added this to the 1.12 milestone Mar 4, 2015
@mrjoelkemp
Copy link
Member

The history details when the first breaking build occurred: https://ci.appveyor.com/project/mdevils/node-jscs/history. That's odd, since I know that https://ci.appveyor.com/project/mdevils/node-jscs/build/156 for sure had passing checks.

I reached out to AppVeyor to see what's up: https://twitter.com/mrjoelkemp/status/573114388196028416

@mrjoelkemp
Copy link
Member

Heard back from AppVeyor. The logs open properly in Firefox.

You'll see 484 passing and 2697 tests failing. https://ci.appveyor.com/project/mdevils/node-jscs/build/157

@qfox
Copy link
Member Author

qfox commented Mar 5, 2015

I'm not sure that this is an appveyor bug. I can repeat this with 1.4.3 iojs on win7 machine. Exactly the same error set. ;-(

Btw, v1.4.3 on my linux box also fails with:

../deps/uv/src/unix/stream.c:1174: uv_shutdown: Assertion `(stream->type == UV_TCP || stream->type == UV_NAMED_PIPE) && "uv_shutdown (unix) only supports uv_handle_t right now"' failed.

on mocha call.

qfox pushed a commit to qfox/node-jscs that referenced this issue Mar 5, 2015
qfox pushed a commit that referenced this issue Mar 5, 2015
@qfox
Copy link
Member Author

qfox commented Mar 5, 2015

Okay, it's definitely iojs v1.4.1+ trouble. I suggest to freeze nodejs version for appveyor to 0.12 or 0.10 and 0.12.

@mrjoelkemp
Copy link
Member

Mind modifying the config as necessary?

@qfox qfox closed this as completed in e554fb9 Mar 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants