Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Appveyor: freeze stable node version #1141

Closed
wants to merge 1 commit into from
Closed

Conversation

qfox
Copy link
Member

@qfox qfox commented Mar 5, 2015

Fixes #1136

@qfox qfox force-pushed the appveyor-node-version branch 2 times, most recently from 3f770d3 to e312797 Compare March 5, 2015 02:00
@qfox
Copy link
Member Author

qfox commented Mar 5, 2015

@mrjoelkemp Seems like all is fine with 0.10/0.12.

Should we test both stables or just 0.12 (as latest stable)?

cc @mikesherov @markelog @mdevils

@qfox qfox changed the title trying to fix appveyor Appveyor: freeze stable node version Mar 5, 2015
qfox pushed a commit to qfox/node-jscs that referenced this pull request Mar 5, 2015
@qfox qfox force-pushed the appveyor-node-version branch from e312797 to 558d706 Compare March 5, 2015 02:46
@qfox qfox force-pushed the appveyor-node-version branch from 558d706 to 612697d Compare March 5, 2015 02:47
@mrjoelkemp
Copy link
Member

Testing the two versions separately would be nice for isolating v0.12 bugs, if any.

@ghost ghost mentioned this pull request Mar 5, 2015
@qfox
Copy link
Member Author

qfox commented Mar 5, 2015

@mrjoelkemp Yes, but we already testing them in travis. And since appveyor tests much slower we can skip them.

Anyway if bug exists I should go & look into it and check manually both versions. As addition: there are no much windows specific bugs so I think we can left just the latest.

@mikesherov
Copy link
Contributor

I like this as is 👍

@mrjoelkemp
Copy link
Member

👍

@qfox qfox closed this in e554fb9 Mar 5, 2015
@qfox qfox deleted the appveyor-node-version branch March 5, 2015 17:17
@qfox
Copy link
Member Author

qfox commented Mar 5, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appveyor: fixup tests and check work on win
3 participants