-
Notifications
You must be signed in to change notification settings - Fork 88
JSX elements are not being linted fully #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like there is a disagreement between airbnb and people working on react itself, see facebook/create-react-app#87 (comment) Personally I think I agree with @Gaeron's perspective. |
I am happy to follow the no jsx files convention BUT I am seeing some horrible interaction with our current linting configuration files case in point if you rename AddContent.test.js to AddContent.test.jsx then you get new linting errors
I am going to look into this more so that we get the same error warning from js files with JSX elements. |
Nice, thank you! |
Great - the loose ends are complete and merged.. thank you. |
This maybe a deliberate design choice that I am ignorant of
BUT
we are getting compile errors in relation to storybook when we have JSX elements inside js files
[ that is being fixed here #554 as part of #546 ]
This issue is separate I just want clearance to lock this down so that all files using JSX elements have the extension jsx or tsx.
The text was updated successfully, but these errors were encountered: