AddContent: Replace div with fragment #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#555
The parent issue identifier that typescript files were not being linted. Another PR rename files containing typescript to AddContent.test.js and AddContent.test.jsx
This PR now fixes one of the outstanding lint errors
Markup is wrapped in a ListItemText element and so as we sanitize it is inappropriate to use Markup's default of a div as an internal wrapper.
#555 (comment)
Here is the lint warning
looking at the valid values for tagName in Markup -- "span" or "fragment" are the only possibilities
fragment has the advantage of dissolving into nothing.