Skip to content

Storybook files with JSX elements need the correct file extension #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Storybook files with JSX elements need the correct file extension #554

wants to merge 2 commits into from

Conversation

martinfrances107
Copy link
Contributor

Issue

#546

This is only a partial fix for the broken story book issue.

files containing JSX elements must have the file extension jsx

recent changes enforce that rule and hence storybook is broken.

@martinfrances107
Copy link
Contributor Author

This is a question about linting standards looking at the master branch of drupal-admin-ui the question is the entry in .eslintrc.json look broken, but is maybe deliberate it

jsx elements are allowed in .js files ... this seems wrong but to correct that would be a PR which changes 41 file extensions..

I am leaving that alone and just allowing jsx elements in jsx files. which is cause the current lint problems.

@dawehner
Copy link
Contributor

May I ask why we care about renaming to .jsx files when all the normal react components are named .js ?

@martinfrances107
Copy link
Contributor Author

I am going to close this PR down .. thank you for paying attention.

Our eslint/build configuration is not linting/parsing jsx elements in js files fully or correctly. ( #555) Once we solve that problem them the storybook aspect of our project will be reanimated.

@dawehner
Copy link
Contributor

@martinfrances107 Thank you!

@martinfrances107 martinfrances107 deleted the StoriesJSX branch November 23, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants