Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wait for upstream] [jsk_pr2_startup, jsk_fetch_startup] use app_manager as plugin #1083

Merged
merged 6 commits into from
Jun 26, 2019

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented May 22, 2019

split from #1081
load apps as plugin
cc. @furushchev

@k-okada
Copy link
Member

k-okada commented May 23, 2019

@708yamaguchi please check on Fetch robot

@knorth55 knorth55 changed the title use app_manager as plugin [jsk_pr2_startup, jsk_fetch_startup] use app_manager as plugin May 23, 2019
@knorth55
Copy link
Member Author

knorth55 commented May 23, 2019

@708yamaguchi @k-okada I tested with fetch15 and it works.

fetch@fetch15:~/ros/indigo/src/jsk-ros-pkg/jsk_robot/jsk_fetch_robot/jsk_fetch_startup$ rospack plugins --attrib=app_dir app_manager
jsk_fetch_startup /home/fetch/ros/indigo/src/jsk-ros-pkg/jsk_robot/jsk_fetch_robot/jsk_fetch_startup/apps
jsk_pr2_startup /home/fetch/ros/indigo/src/jsk-ros-pkg/jsk_robot/jsk_pr2_robot/jsk_pr2_startup/apps

/var/log/upstart/jsk-fetch-startup.log

[INFO] [WallTime: 1558612901.923929] Client connected.  1 clients total.
[INFO] [WallTime: 1558612902.273419] [Client 0] Subscribed to /fetch15/app_list
[INFO] [WallTime: 1558612911.194977] start_app: jsk_fetch_startup/hello_world
[INFO] [WallTime: 1558612911.195209] Loading app: jsk_fetch_startup/hello_world
[INFO] [WallTime: 1558612912.072172] Launching: /home/fetch/ros/indigo/src/jsk-ros-pkg/jsk_robot/jsk_fetch_robot/jsk_fetch_startup/apps/hello_world/hello_world.xml
started roslaunch server http://fetch15:55140/

SUMMARY
========

PARAMETERS
 * /rosdistro: indigo
 * /rosversion: 1.11.21

NODES
  /
    run_hello_world (jsk_fetch_startup/boot_sound.py)

ROS_MASTER_URI=http://localhost:11311
core service [/rosout] found
process[run_hello_world-1]: started with pid [13437]
[INFO] [WallTime: 1558612912.522123] Waiting for foreign master [http://localhost:11313] to come up...
[INFO] [WallTime: 1558612912.523723] Foreign master is available
[run_hello_world-1] process has finished cleanly
log file: /home/fetch/.ros/log/6a608bf8-7d52-11e9-a43b-d8cb8a40210c/run_hello_world-1*.log
all processes on machine have died, roslaunch will exit
[INFO] [WallTime: 1558612926.165813] handle stop app: stopping app [jsk_fetch_startup/hello_world]
[INFO] [WallTime: 1558612926.545750] handle stop app: app [jsk_fetch_startup/hello_world] stopped

@708yamaguchi
Copy link
Member

I also tested app_manager with knorth55/app-manager branch.

I did hello world app on real Fetch robot.

@knorth55
Copy link
Member Author

knorth55 commented Jun 6, 2019

Test failed because app_manager 1.1.1 is not released in both kinetic and melodic.
I made a release request 1.1.1 in app_manager.
However, we need to install app_manger by source because inddigo which runs in PR2 and fetch is EOL.
PR2/app_manager#12

@knorth55 knorth55 changed the title [jsk_pr2_startup, jsk_fetch_startup] use app_manager as plugin [Wait for upstream] [jsk_pr2_startup, jsk_fetch_startup] use app_manager as plugin Jun 6, 2019
@k-okada k-okada merged commit fd4d7db into jsk-ros-pkg:master Jun 26, 2019
@knorth55 knorth55 deleted the app-manager branch June 26, 2019 04:59
@knorth55
Copy link
Member Author

We need this release for build passing.
PR2/app_manager#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants