Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

launch all sound play nodes in pr2_bringup.launch #1088

Closed
wants to merge 1 commit into from
Closed

launch all sound play nodes in pr2_bringup.launch #1088

wants to merge 1 commit into from

Conversation

knorth55
Copy link
Member

split from #1081
launch all sound play nodes in pr2_bringup.launch
cc. @furushchev

@knorth55 knorth55 mentioned this pull request May 22, 2019
Closed
5 tasks
@k-okada
Copy link
Member

k-okada commented May 23, 2019

do we really need this? My understanding is; this change enable PR2 robot to speak Japanese before we launch jsk_pr2_startup pr2.launch. If this is correct, I do not think we need this, if there is some node that start before jsk_pr2_startup pr2.launch and speaks in Japanese, then that node should speak in English.

@knorth55
Copy link
Member Author

knorth55 commented May 23, 2019 •
edited
Loading

@k-okada
Probably, you are right.
i will close this PR.

@knorth55 knorth55 closed this May 23, 2019
@knorth55 knorth55 deleted the pr2-sound-play branch May 23, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knorth55 @k-okada