Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameters for navigation / safe_teleop #1178

Merged
merged 35 commits into from
Dec 3, 2019

Conversation

YutoUchimi
Copy link
Contributor

@YutoUchimi YutoUchimi commented Nov 18, 2019

Split from #1143

Summary of commits by @furushchev

  • Use 2d costmap: VoxelLayer -> ObstacleLayer.
  • Fix laser topics used for obstacle observation in move_base.
  • Adjust params for move base tilt observation persistence.
  • Update safe teleop params.

Summary of commits by @iory

  • Add option to use teb_local_planner.

Summary of commits by @knorth55

  • Use move_base local costmap parameter for safe teleop base.

Summary of commits by @YutoUchimi

  • Use pentagonal footstep polygon.
  • Use omni-corrected model type and set valid parameters for that type.
  • Update amcl parameters for robust localization against wheel slipping.
  • Limit max_vel_y to avoid running like a crab.
  • Decrease sim_time and increase controller_frequency to avoid frequent navigation chattering on real robot which occurs when forward simulation is not finished in the timeout.
  • Increase min_obstacle_height so as not to observe some noised points on floor plane from tilt laser.
  • Increase padding of tilt_laser_self_filter not to regard PR2's links as obstacle while moving base.
  • Explicitly disable recovery_behavior which is hard to notice because max_planning_retries is set to -1 in default, which actually disables recovery_behavior.
  • Update params for cost calculation used during global planning.
  • Do not allow to plan to go through unknown space.
  • Allow small translational movement when rotating in place to enable to move in '-x' direction.

furushchev and others added 30 commits November 18, 2019 13:37
@YutoUchimi
Copy link
Contributor Author

I chery-picked b58bd64 by mistake.
It should be merged into #1121 , so I reverted that commit from this PR.

@k-okada
Copy link
Member

k-okada commented Nov 25, 2019

please check on fridge demo with @takayuki5168

@takayuki5168
Copy link
Contributor

takayuki5168 commented Dec 2, 2019

@k-okada I checked fridge demo with @HiroIshida 6 times last week. There are some below failures, but anything below has nothing to do with this PR.

  • Tilt laser device was not recognized.
    • After rebooting PR2 by circuit breaker, the device was found, but costmap is abnormal. The cost in front of PR2 is light blue, which means PR2 could not move at all.
    • After recalibrating tilt laser twice, the costmap becomes normal, and everything worked with demo. So we think that the calibration of tilt laser became shifted as time passed by.
  • TF was not published. After rebooting PR2, everything worked with demo.

@k-okada k-okada merged commit 4fbd7c9 into jsk-ros-pkg:master Dec 3, 2019
@YutoUchimi YutoUchimi deleted the pr2_navigation_param branch December 3, 2019 11:21
@knorth55 knorth55 mentioned this pull request Sep 11, 2022
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants