Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[merge after #1208 and #1371] Fetch melodic and new hardware support #1328

Merged
merged 35 commits into from
Sep 25, 2021

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Apr 5, 2021

This PR supports Fetch-JSK support (Melodic + JSK hardware)

this PR depends on #1208 and #1371, please merge after #1208 and #1371

Thank you @sktometometo @708yamaguchi

@knorth55 knorth55 changed the title Fetch Melodic and new hardware support Fetch melodic and new hardware support Apr 8, 2021
@knorth55 knorth55 force-pushed the fetch-melodic-support branch 2 times, most recently from 5c8178a to 97ae4b4 Compare September 12, 2021 15:45
@knorth55 knorth55 mentioned this pull request Sep 12, 2021
@knorth55 knorth55 force-pushed the fetch-melodic-support branch from 6fe896a to 88ced0c Compare September 18, 2021 10:31
@k-okada
Copy link
Member

k-okada commented Sep 19, 2021

@708yamaguchi sorry, please fix conflicts

@knorth55 knorth55 force-pushed the fetch-melodic-support branch 3 times, most recently from 9420ddb to 8b67455 Compare September 19, 2021 17:21
@knorth55 knorth55 changed the title Fetch melodic and new hardware support [merge after #1208] Fetch melodic and new hardware support Sep 19, 2021
@knorth55 knorth55 changed the title [merge after #1208] Fetch melodic and new hardware support [merge after #1208 and #1371] Fetch melodic and new hardware support Sep 19, 2021
@knorth55 knorth55 force-pushed the fetch-melodic-support branch 2 times, most recently from 1c3cfb3 to 8b67455 Compare September 20, 2021 04:04
@knorth55
Copy link
Member Author

test failed because jsk_perception with sample_insta360.launch is not released yet.
I changed to check fetch_bringup.launch with launch_insta360:=false for skipping the build failure.

@knorth55 knorth55 mentioned this pull request Sep 20, 2021
12 tasks
@knorth55 knorth55 force-pushed the fetch-melodic-support branch from e2c88b9 to 1971052 Compare September 21, 2021 06:39
@knorth55 knorth55 force-pushed the fetch-melodic-support branch from 0522ec2 to 455daef Compare September 24, 2021 13:38
@knorth55
Copy link
Member Author

all travis passed.

@k-okada k-okada merged commit dd6672e into jsk-ros-pkg:master Sep 25, 2021
@knorth55 knorth55 deleted the fetch-melodic-support branch September 25, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants