Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import error on base_trajectory_logger.py #1359

Merged
merged 3 commits into from
Jul 18, 2021

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Jul 17, 2021

closes #1357 by

    chmod a-x
    jsk_robot_startup/src/jsk_robot_startup/OdometryFeedbackWrapper.py and
    jsk_robot_startup/src/jsk_robot_startup/lifelog/base_trajectory_logger.py

should we remove
https://github.com/k-okada/jsk_robot/blob/0c79ce93ce4ed3a6380ad4820c1546ad207770be/jsk_robot_common/jsk_robot_startup/src/jsk_robot_startup/lifelog/base_trajectory_logger.py#L163-L165 ?

…pper.py and jsk_robot_startup/src/jsk_robot_startup/lifelog/base_trajectory_logger.py
@k-okada k-okada requested a review from knorth55 July 17, 2021 14:57
@knorth55
Copy link
Member

@k-okada thank you.
I confirmed this PR works in PR2.

should we remove
k-okada/jsk_robot@0c79ce9/jsk_robot_common/jsk_robot_startup/src/jsk_robot_startup/lifelog/base_trajectory_logger.py#L163-L165 ?

either is ok, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relative import fails in pr1040
2 participants