Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_robot_startup] add check_use_sim_time app #1381

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

knorth55
Copy link
Member

this PR adds app for checking and overriding /use_sim_time parameter on real robot.
we run this app every 10 minutes on PR1040.

@shmpwk

@knorth55
Copy link
Member Author

@708yamaguchi maybe this is useful for fetch, too.

@shmpwk
Copy link
Contributor

shmpwk commented Sep 18, 2021

Interesting! Does thie picture show up somewhere?
I cannot get one even when I execute rosparam set /use_sim_time true in PR2 and he says he will overwrite /use_sim_time with false.

@knorth55
Copy link
Member Author

what do you mean? the picture?

@knorth55
Copy link
Member Author

PR2 run this app every 10 minutes, so tou need to wait for it

@shmpwk
Copy link
Contributor

shmpwk commented Sep 18, 2021

I mean check_use_sim_time.png won't show up in 10 minutes at all.
I don't know how it works.

@knorth55
Copy link
Member Author

?
the png is just an icon for rwt_app_chooser

@shmpwk
Copy link
Contributor

shmpwk commented Sep 18, 2021

Thank you for teaching me rwt_app_chooser, I didn't now that.

@k-okada k-okada merged commit e272982 into jsk-ros-pkg:master Sep 22, 2021
@knorth55 knorth55 deleted the check-use-sim-time-app branch September 22, 2021 05:08
@k-okada
Copy link
Member

k-okada commented Sep 22, 2021

Nice. note that the icon is copied from https://www.irasutoya.com/2018/07/blog-post_935.html. I believe newness of software or paper is not important, but icon and picture must be unique and original.

c.f. https://www.youtube.com/watch?v=W3w0ZtGw5fQ&t=1845s

@knorth55 knorth55 mentioned this pull request Sep 11, 2022
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants