Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Django 4.2 #284

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Test on Django 4.2 #284

merged 1 commit into from
Apr 16, 2023

Conversation

adamchainz
Copy link
Collaborator

No description provided.

@adamchainz adamchainz requested a review from jsocol April 15, 2023 12:56
python \
-W error::ResourceWarning \
-W error::DeprecationWarning \
-W error::PendingDeprecationWarning \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only targeted for the Django 4.2 tests? Just thinking that it's a shame in Django 4.3 to miss new warnings.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django's RemovedInDjangoXYWarning warnings are floating between DeprecationWarning and PendingDeprecationWarning depending on the current version: https://github.com/django/django/blob/main/django/utils/deprecation.py#L7-L12

(Also there won't be a Django 4.3, just a 5.0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I read it wrongly, I'm too used to these patterns always being about silencing warnings. This is the thing we want 💯

Comment on lines +29 to +32
- python-version: '3.11'
django: '3.2'
- python-version: '3.11'
django: '4.0'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django 3.2 and 4.0 do not support Python 3.11. Also edited in tox.ini

Comment on lines +23 to +30
python \
-W error::ResourceWarning \
-W error::DeprecationWarning \
-W error::PendingDeprecationWarning \
-m django \
test \
django_ratelimit \
"$@"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this warning config which I use on my projects to ensure that my package does not trigger warnings for users.

@adamchainz
Copy link
Collaborator Author

There are two expected test runs which are the ones that I've removed, so they need removing from the branch protection rule.

@jsocol
Copy link
Owner

jsocol commented Apr 16, 2023

Thank you for this! Also adjusted the branch protection rules to remove Dj3.2/Py3.11 and Dj4.0/Py3.11

@jsocol jsocol merged commit 7a6d04c into jsocol:main Apr 16, 2023
@adamchainz adamchainz deleted the django_4.2 branch May 18, 2023 07:56
@jsocol jsocol mentioned this pull request Jul 24, 2023
jsocol added a commit that referenced this pull request Jul 24, 2023
Additions:
----------

- Add RATELIMITE_HASH_ALGORITHM setting (#282, #285)

Minor changes:
--------------

- Fixed links in docs (#277)
- Test on Django 4.2 (#284)
@adamchainz adamchainz mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants