-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on Django 4.2 #284
Test on Django 4.2 #284
Conversation
python \ | ||
-W error::ResourceWarning \ | ||
-W error::DeprecationWarning \ | ||
-W error::PendingDeprecationWarning \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only targeted for the Django 4.2 tests? Just thinking that it's a shame in Django 4.3 to miss new warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django's RemovedInDjangoXYWarning
warnings are floating between DeprecationWarning
and PendingDeprecationWarning
depending on the current version: https://github.com/django/django/blob/main/django/utils/deprecation.py#L7-L12
(Also there won't be a Django 4.3, just a 5.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! I read it wrongly, I'm too used to these patterns always being about silencing warnings. This is the thing we want 💯
- python-version: '3.11' | ||
django: '3.2' | ||
- python-version: '3.11' | ||
django: '4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django 3.2 and 4.0 do not support Python 3.11. Also edited in tox.ini
python \ | ||
-W error::ResourceWarning \ | ||
-W error::DeprecationWarning \ | ||
-W error::PendingDeprecationWarning \ | ||
-m django \ | ||
test \ | ||
django_ratelimit \ | ||
"$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this warning config which I use on my projects to ensure that my package does not trigger warnings for users.
There are two expected test runs which are the ones that I've removed, so they need removing from the branch protection rule. |
Thank you for this! Also adjusted the branch protection rules to remove Dj3.2/Py3.11 and Dj4.0/Py3.11 |
No description provided.