-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on Django 5.0 #306
Test on Django 5.0 #306
Conversation
python-version: | ||
- '3.7' | ||
- '3.8' | ||
- '3.9' | ||
- '3.10' | ||
- '3.11' | ||
django: | ||
- '3.2' | ||
- '4.0' | ||
- '4.1' | ||
- '4.2' | ||
- '5.0' | ||
- 'main' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broke out into one-per-line to reduce future diff noise when adding/removing versions
- python-version: '3.7' | ||
django: '4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest a follow-up PR to remove 3.7, since it’s EOL. Sound good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely—I'll take care of that, thank you!
11b7a71
to
14b29e8
Compare
14b29e8
to
83b5857
Compare
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] | ||
django: ['3.2', '4.0', '4.1'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized this duplicated actions file wasn't updated in the past 😕. Maybe there’s a way to reduce the duplication more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked for ways to move the matrix into the task but I couldn't find any. It's probably OK to do a significantly reduced set here, anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
- python-version: '3.7' | ||
django: '4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely—I'll take care of that, thank you!
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] | ||
django: ['3.2', '4.0', '4.1'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked for ways to move the matrix into the task but I couldn't find any. It's probably OK to do a significantly reduced set here, anyway
Repeating the changes from #284 for the newest Django.