Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added language to explicitly specify behavior when a vocab is known #1022

Merged
merged 3 commits into from
Nov 22, 2020
Merged

added language to explicitly specify behavior when a vocab is known #1022

merged 3 commits into from
Nov 22, 2020

Conversation

gregsdennis
Copy link
Member

No description provided.

@gregsdennis gregsdennis changed the title resolves #1019 - added language to explicitly specify behavior when a vocab is known added language to explicitly specify behavior when a vocab is known Nov 19, 2020
@Relequestual Relequestual linked an issue Nov 19, 2020 that may be closed by this pull request
$vocabulary:{<vocab>:false} when a vocab is recognized is not defined #1019
Closed
Relequestual
Relequestual previously requested changes Nov 19, 2020
View reviewed changes
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single change suggestion. Semantics! 🙄

Otherwise, this PR is good to go.
Thanks for your effort in making it happen =]

@gregsdennis @Relequestual
Update jsonschema-core.xml
fd40243 
Co-authored-by: Ben Hutton <relequestual@gmail.com>
@gregsdennis
Copy link
Member Author

merge when ready

@karenetheridge
Copy link
Member

Is a footnote necessary, to indicate that the handling for the format vocabulary is special-cased?

@gregsdennis
Copy link
Member Author

gregsdennis commented Nov 20, 2020 •
edited
Loading

@karenetheridge no. Please see #1023 / #1026 for changes to format, which remove the special-case treatment. This change is purely for vocabularies.

@gregsdennis gregsdennis dismissed Relequestual’s stale review November 20, 2020 20:16

applied suggested changes

@gregsdennis gregsdennis removed the request for review from handrews November 21, 2020 11:46
@Relequestual Relequestual merged commit e6bead3 into master Nov 22, 2020
@handrews handrews deleted the issue-1019-known-vocabs-are-always-processed branch October 17, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenetheridge karenetheridge karenetheridge approved these changes

@Relequestual Relequestual Relequestual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
draft-08-patch1 (draft 2020-12)
Development

Successfully merging this pull request may close these issues.

$vocabulary:{<vocab>:false} when a vocab is recognized is not defined
3 participants
@gregsdennis @karenetheridge @Relequestual