Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reworked 'format' to default to annotation except when configured for assertion #1023

Closed
wants to merge 1 commit into from
Closed

reworked 'format' to default to annotation except when configured for assertion #1023

wants to merge 1 commit into from

Conversation

gregsdennis
Copy link
Member

@gregsdennis gregsdennis commented Nov 19, 2020 •
edited
Loading

There is also this in the "Custom format attributes" section below the edits:

An implementation MUST NOT fail validation or cease processing due to an unknown format attribute.

What is an implementation to do when an unknown format is encountered other than fail?

Closes #1026.
Closes #1027.

@gregsdennis gregsdennis changed the title resolves #1020 - reworked 'format' to default to annotation except when configured for assertion reworked 'format' to default to annotation except when configured for assertion Nov 19, 2020
@Relequestual Relequestual linked an issue Nov 19, 2020 that may be closed by this pull request
format should not change behavior based on its vocabulary value #1020
Closed
@Relequestual
Copy link
Member

I'm not in favour of this change at this time.
I have explained why here: #1020 (comment)

@gregsdennis gregsdennis mentioned this pull request Nov 20, 2020
Merged
@gregsdennis
Copy link
Member Author

Alternative change in #1026.

@gregsdennis gregsdennis mentioned this pull request Nov 20, 2020
Closed
@gregsdennis gregsdennis removed the request for review from handrews November 21, 2020 11:46
@gregsdennis gregsdennis mentioned this pull request Nov 21, 2020
Merged
@gregsdennis gregsdennis mentioned this pull request Jul 5, 2021
Open
@gregsdennis gregsdennis deleted the issue-1020-format-is-always-annotation branch September 20, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Relequestual Relequestual Awaiting requested review from Relequestual

@karenetheridge karenetheridge Awaiting requested review from karenetheridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
draft-08-patch1 (draft 2020-12)
Development

Successfully merging this pull request may close these issues.

format should not change behavior based on its vocabulary value
2 participants
@gregsdennis @Relequestual