Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Logging with a color formatter #412

Merged
merged 5 commits into from
Dec 5, 2024
Merged

[ENH]: Logging with a color formatter #412

merged 5 commits into from
Dec 5, 2024

Conversation

fraimondo
Copy link
Contributor

Taking advantage of the xterm-colors... this PR adds colors to logging messages.

Screenshot 2024-12-05 at 10 47 17

It also allows to set the datalad logger to a different level than the one from junifer, allowing to debug junifer without the million debugging messages from datalad.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 0.01%. Comparing base (8e4381a) to head (5cdba91).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
junifer/utils/logging.py 0.00% 41 Missing ⚠️
junifer/cli/cli.py 0.00% 15 Missing ⚠️
...er/api/queue_context/gnu_parallel_local_adapter.py 0.00% 7 Missing ⚠️
junifer/api/queue_context/htcondor_adapter.py 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #412      +/-   ##
========================================
- Coverage   0.01%   0.01%   -0.01%     
========================================
  Files        133     133              
  Lines       5615    5676      +61     
========================================
  Hits           1       1              
- Misses      5614    5675      +61     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er/api/queue_context/gnu_parallel_local_adapter.py 0.00% <0.00%> (ø)
junifer/api/queue_context/htcondor_adapter.py 0.00% <0.00%> (ø)
junifer/cli/cli.py 0.00% <0.00%> (ø)
junifer/utils/logging.py 0.00% <0.00%> (ø)

junifer/utils/logging.py Show resolved Hide resolved
junifer/utils/logging.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 5, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-05 16:03 UTC

Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a newsfragment and it's good to go.

@synchon synchon added the enhancement New feature or request label Dec 5, 2024
@synchon synchon added this to the 0.0.6 (alpha 5) milestone Dec 5, 2024
@synchon synchon changed the title [ENH] Logging with a color formatter [ENH]: Logging with a color formatter Dec 5, 2024
@synchon synchon merged commit 6c0c909 into main Dec 5, 2024
20 of 23 checks passed
@synchon synchon deleted the enh/color_format branch December 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants