Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Logging with a color formatter #412

Merged
merged 5 commits into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changes/newsfragments/412.change
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Introduce new CLI parameter ``--verbose-datalad`` to control ``datalad``'s logging handler by `Fede Raimondo`_
1 change: 1 addition & 0 deletions docs/changes/newsfragments/412.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add support for coloured :class:`logging.Formatter` to use with ``junifer``'s :class:`logging.StreamHandler` based on environment by `Fede Raimondo`_
19 changes: 17 additions & 2 deletions junifer/api/queue_context/gnu_parallel_local_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ class GnuParallelLocalAdapter(QueueContextAdapter):
virtual environment of any kind (default None).
verbose : str, optional
The level of verbosity (default "info").
verbose_datalad : str or None, optional
The level of verbosity for datalad. If None, will be the same
as ``verbose`` (default None).
submit : bool, optional
Whether to submit the jobs (default False).

Expand Down Expand Up @@ -65,6 +68,7 @@ def __init__(
pre_collect: Optional[str] = None,
env: Optional[dict[str, str]] = None,
verbose: str = "info",
verbose_datalad: Optional[str] = None,
submit: bool = False,
) -> None:
"""Initialize the class."""
Expand All @@ -76,6 +80,7 @@ def __init__(
self._pre_collect = pre_collect
self._check_env(env)
self._verbose = verbose
self._verbose_datalad = verbose_datalad
self._submit = submit

self._log_dir = self._job_dir / "logs"
Expand Down Expand Up @@ -155,6 +160,11 @@ def pre_run(self) -> str:

def run(self) -> str:
"""Return run commands."""
verbose_args = f"--verbose {self._verbose}"
if self._verbose_datalad:
verbose_args = (
f"{verbose_args} --verbose-datalad {self._verbose_datalad}"
)
return (
f"#!/usr/bin/env {self._shell}\n\n"
"# This script is auto-generated by junifer.\n\n"
Expand All @@ -169,7 +179,7 @@ def run(self) -> str:
f"{self._job_dir.resolve()!s}/{self._executable} "
f"{self._arguments} run "
f"{self._yaml_config_path.resolve()!s} "
f"--verbose {self._verbose} "
f"{verbose_args} "
f"--element"
)

Expand All @@ -184,6 +194,11 @@ def pre_collect(self) -> str:

def collect(self) -> str:
"""Return collect commands."""
verbose_args = f"--verbose {self._verbose}"
if self._verbose_datalad:
verbose_args = (
f"{verbose_args} --verbose-datalad {self._verbose_datalad}"
)
return (
f"#!/usr/bin/env {self._shell}\n\n"
"# This script is auto-generated by junifer.\n\n"
Expand All @@ -193,7 +208,7 @@ def collect(self) -> str:
f"{self._job_dir.resolve()!s}/{self._executable} "
f"{self._arguments} collect "
f"{self._yaml_config_path.resolve()!s} "
f"--verbose {self._verbose}"
f"{verbose_args}"
)

def prepare(self) -> None:
Expand Down
20 changes: 18 additions & 2 deletions junifer/api/queue_context/htcondor_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ class HTCondorAdapter(QueueContextAdapter):
virtual environment of any kind (default None).
verbose : str, optional
The level of verbosity (default "info").
verbose_datalad : str or None, optional
The level of verbosity for datalad. If None, will be the same
as ``verbose`` (default None).
cpus : int, optional
The number of CPU cores to use (default 1).
mem : str, optional
Expand Down Expand Up @@ -83,6 +86,7 @@ def __init__(
pre_collect: Optional[str] = None,
env: Optional[dict[str, str]] = None,
verbose: str = "info",
verbose_datalad: Optional[str] = None,
cpus: int = 1,
mem: str = "8G",
disk: str = "1G",
Expand All @@ -99,6 +103,7 @@ def __init__(
self._pre_collect = pre_collect
self._check_env(env)
self._verbose = verbose
self._verbose_datalad = verbose_datalad
self._cpus = cpus
self._mem = mem
self._disk = disk
Expand Down Expand Up @@ -201,10 +206,15 @@ def pre_run(self) -> str:

def run(self) -> str:
"""Return run commands."""
verbose_args = f"--verbose {self._verbose} "
if self._verbose_datalad is not None:
verbose_args = (
f"{verbose_args} --verbose-datalad {self._verbose_datalad} "
)
junifer_run_args = (
"run "
f"{self._yaml_config_path.resolve()!s} "
f"--verbose {self._verbose} "
f"{verbose_args}"
"--element $(element)"
)
log_dir_prefix = (
Expand Down Expand Up @@ -246,10 +256,16 @@ def pre_collect(self) -> str:

def collect(self) -> str:
"""Return collect commands."""
verbose_args = f"--verbose {self._verbose} "
if self._verbose_datalad is not None:
verbose_args = (
f"{verbose_args} --verbose-datalad {self._verbose_datalad} "
)

junifer_collect_args = (
"collect "
f"{self._yaml_config_path.resolve()!s} "
f"--verbose {self._verbose}"
f"{verbose_args}"
)
log_dir_prefix = f"{self._log_dir.resolve()!s}/junifer_collect"
fixed = (
Expand Down
90 changes: 83 additions & 7 deletions junifer/cli/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,32 @@
]


def _validate_optional_verbose(
ctx: click.Context, param: str, value: Optional[str]
):
"""Validate optional verbose option.

Parameters
----------
ctx : click.Context
The context of the command.
param : str
The parameter to validate.
value : str
The value to validate.

Returns
-------
str or int or None
The validated value.

"""
if value is None:
return value
else:
return _validate_verbose(ctx, param, value)


def _validate_verbose(
ctx: click.Context, param: str, value: str
) -> Union[str, int]:
Expand Down Expand Up @@ -105,8 +131,17 @@ def cli() -> None: # pragma: no cover
callback=_validate_verbose,
default="info",
)
@click.option(
"--verbose-datalad",
type=click.UNPROCESSED,
callback=_validate_optional_verbose,
default=None,
)
def run(
filepath: click.Path, element: tuple[str], verbose: Union[str, int]
filepath: click.Path,
element: tuple[str],
verbose: Union[str, int],
verbose_datalad: Optional[Union[str, int]],
) -> None:
"""Run feature extraction.

Expand All @@ -120,10 +155,12 @@ def run(
The element(s) to operate on.
verbose : click.Choice
The verbosity level: warning, info or debug (default "info").
verbose_datalad : click.Choice or None
The verbosity level for datalad: warning, info or debug (default None).

"""
# Setup logging
configure_logging(level=verbose)
configure_logging(level=verbose, level_datalad=verbose_datalad)
# TODO(synchon): add validation
# Parse YAML
config = parse_yaml(filepath)
Expand Down Expand Up @@ -167,7 +204,17 @@ def run(
callback=_validate_verbose,
default="info",
)
def collect(filepath: click.Path, verbose: Union[str, int]) -> None:
@click.option(
"--verbose-datalad",
type=click.UNPROCESSED,
callback=_validate_optional_verbose,
default=None,
)
def collect(
filepath: click.Path,
verbose: Union[str, int],
verbose_datalad: Union[str, int, None],
) -> None:
"""Collect extracted features.

\f
Expand All @@ -178,10 +225,12 @@ def collect(filepath: click.Path, verbose: Union[str, int]) -> None:
The filepath to the configuration file.
verbose : click.Choice
The verbosity level: warning, info or debug (default "info").
verbose_datalad : click.Choice or None
The verbosity level for datalad: warning, info or debug (default None).

"""
# Setup logging
configure_logging(level=verbose)
configure_logging(level=verbose, level_datalad=verbose_datalad)
# TODO: add validation
# Parse YAML
config = parse_yaml(filepath)
Expand All @@ -208,12 +257,19 @@ def collect(filepath: click.Path, verbose: Union[str, int]) -> None:
callback=_validate_verbose,
default="info",
)
@click.option(
"--verbose-datalad",
type=click.UNPROCESSED,
callback=_validate_optional_verbose,
default=None,
)
def queue(
filepath: click.Path,
element: tuple[str],
overwrite: bool,
submit: bool,
verbose: Union[str, int],
verbose_datalad: Union[str, int, None],
) -> None:
"""Queue feature extraction.

Expand All @@ -231,6 +287,8 @@ def queue(
Whether to submit the job.
verbose : click.Choice
The verbosity level: warning, info or debug (default "info").
verbose_datalad : click.Choice or None
The verbosity level for datalad: warning, info or debug (default None).

Raises
------
Expand All @@ -239,7 +297,7 @@ def queue(

"""
# Setup logging
configure_logging(level=verbose)
configure_logging(level=verbose, level_datalad=verbose_datalad)
# TODO: add validation
# Parse YAML
config = parse_yaml(filepath) # type: ignore
Expand Down Expand Up @@ -365,9 +423,16 @@ def selftest(subpkg: str) -> None:
callback=_validate_verbose,
default="info",
)
@click.option(
"--verbose-datalad",
type=click.UNPROCESSED,
callback=_validate_optional_verbose,
default=None,
)
def reset(
filepath: click.Path,
verbose: Union[str, int],
verbose_datalad: Union[str, int, None],
) -> None:
"""Reset generated assets.

Expand All @@ -379,10 +444,12 @@ def reset(
The filepath to the configuration file.
verbose : click.Choice
The verbosity level: warning, info or debug (default "info").
verbose_datalad : click.Choice or None
The verbosity level for datalad: warning, info or debug (default None).

"""
# Setup logging
configure_logging(level=verbose)
configure_logging(level=verbose, level_datalad=verbose_datalad)
# Parse YAML
config = parse_yaml(filepath)
# Perform operation
Expand All @@ -409,11 +476,18 @@ def reset(
callback=_validate_verbose,
default="info",
)
@click.option(
"--verbose-datalad",
type=click.UNPROCESSED,
callback=_validate_optional_verbose,
default=None,
)
def list_elements(
filepath: click.Path,
element: tuple[str],
output_file: Optional[click.Path],
verbose: Union[str, int],
verbose_datalad: Union[str, int, None],
) -> None:
"""List elements of a dataset.

Expand All @@ -430,10 +504,12 @@ def list_elements(
stdout is not performed.
verbose : click.Choice
The verbosity level: warning, info or debug (default "info").
verbose_datalad : click.Choice or None
The verbosity level for datalad: warning, info or debug (default None

"""
# Setup logging
configure_logging(level=verbose)
configure_logging(level=verbose, level_datalad=verbose_datalad)
# Parse YAML
config = parse_yaml(filepath)
# Fetch datagrabber
Expand Down
Loading
Loading