Add go profiling flag, and enable on integration tests #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
pprof-integration-tests
branch
3 times, most recently
from
561e880
to
aad870f
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
pprof-integration-tests
branch
from
aad870f
to
454808f
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
pprof-integration-tests
branch
from
454808f
to
9b96cfb
Compare
juanfont
approved these changes
Apr 27, 2023
armooo
added a commit
to armooo/headscale
that referenced
this pull request
May 27, 2023
This fixes juanfont#1469, where three bugs pervent main from existing on SIGTERM. The first two are blocking receiving from cancel chanels which never have values sent to them, cancelStateUpdateChan and cancelPolicyUpdateChan. It seems closing the chanels should be all the is needed to signal the watching goroutines to exit. The other is the signal hander never exiting an infinite for loop. The sigFunc is called in an errorGroup which blocks exiting Serve and thus main. It looks like a refactor in juanfont#1382 removed an os.Exit(0), replacing it with a return breaks out of the loop.
armooo
added a commit
to armooo/headscale
that referenced
this pull request
Jun 10, 2023
This fixes juanfont#1469, where three bugs pervent main from existing on SIGTERM. The first two are blocking receiving from cancel chanels which never have values sent to them, cancelStateUpdateChan and cancelPolicyUpdateChan. It seems closing the chanels should be all the is needed to signal the watching goroutines to exit. The other is the signal hander never exiting an infinite for loop. The sigFunc is called in an errorGroup which blocks exiting Serve and thus main. It looks like a refactor in juanfont#1382 removed an os.Exit(0), replacing it with a return breaks out of the loop.
kradalby
pushed a commit
to armooo/headscale
that referenced
this pull request
Jul 7, 2023
This fixes juanfont#1469, where three bugs pervent main from existing on SIGTERM. The first two are blocking receiving from cancel chanels which never have values sent to them, cancelStateUpdateChan and cancelPolicyUpdateChan. It seems closing the chanels should be all the is needed to signal the watching goroutines to exit. The other is the signal hander never exiting an infinite for loop. The sigFunc is called in an errorGroup which blocks exiting Serve and thus main. It looks like a refactor in juanfont#1382 removed an os.Exit(0), replacing it with a return breaks out of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com