Codereorg: Part 5, state #1492
Merged
Codereorg: Part 5, state #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
force-pushed
the
codereorg-p5-state
branch
2 times, most recently
from
631d1a8
to
e4b0e82
Compare
kradalby
force-pushed
the
codereorg-p5-state
branch
4 times, most recently
from
32a0567
to
b5be2ef
Compare
This was referenced Jul 7, 2023
Closed
|
All tests pass locally, it is hard to know if Github actions is reliable or not. |
|
My observation so far is that tests including a larger amount of nodes are more unreliable, particularly with excess network requirements:
|
kradalby
force-pushed
the
codereorg-p5-state
branch
2 times, most recently
from
260c535
to
1b344ac
Compare
kradalby
force-pushed
the
codereorg-p5-state
branch
from
55aca05
to
5b8053f
Compare
kradalby
force-pushed
the
codereorg-p5-state
branch
from
7071644
to
0b4dc82
Compare
kradalby
force-pushed
the
codereorg-p5-state
branch
3 times, most recently
from
546f1f0
to
0864811
Compare
kradalby
force-pushed
the
codereorg-p5-state
branch
from
0864811
to
4bdfde3
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit replaces the timestamp based state system with a new one that has update channels directly to the connected nodes. It will send an update to all listening clients via the polling mechanism. It introduces a new package notifier, which has a concurrency safe manager for all our channels to the connected nodes. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commits extends the mapper with functions for creating "delta" MapResponses for different purposes (peer changed, peer removed, derp). This wires up the new state management with a new StateUpdate struct letting the poll worker know what kind of update to send to the connected nodes. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Co-Authored-By: Jason <armooo@armooo.net> Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
codereorg-p5-state
branch
2 times, most recently
from
93788d5
to
1d7b736
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Closes juanfont#1544 Co-Authored-By: Patrick Huang <huangxiaoman@gmail.com> Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
codereorg-p5-state
branch
from
1d7b736
to
86937b9
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This field is no longer used, it was used in our old state "algorithm" to determine if we should send an update. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit rearranges the poll handler to immediatly accept updates and notify its peers and return, not travel down the function for a bit. This reduces the DB calls and other holdups that isnt necessary to send a "lite response", a map response without peers, or accepting an endpoint update. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
codereorg-p5-state
branch
from
86937b9
to
1f4d51d
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
|
Hello there, I'm start testing this changes, and found bug with "on-the-fly" state update:
|
|
It seems there is also an issue with updating the "last-seen"/"online" status. I wanted to test the subnet-router failover, but as soon as I executed Although there are no network connectivity issues, tailscale is working, and headscale is accessible via http: |
|
@vsychov Thank you, I appreciate this a lot. I think what I will do since this PR is so messy already is to get it in, and then it would be great if you could create two issues for me on this (and other things you find), and then we make them blocking before alpha. I would also appreciate your continued testing of this work. |
|
Approved! |
juanfont
approved these changes
Sep 19, 2023
hscontrol/mapper/mapper.go
Outdated
| changed := make(types.Machines, len(machineKeys)) | ||
| lastSeen := make(map[tailcfg.NodeID]bool) | ||
| for idx, machineKey := range machineKeys { | ||
| peer, err := m.db.GetMachineByID(machineKey) |
There was a problem hiding this comment.
Mixing MachineKey with IDs of the DB?
| } | ||
|
|
||
| func NewNotifier() *Notifier { | ||
| return &Notifier{} | ||
| } | ||
|
|
||
| func (n *Notifier) AddNode(machineKey string, c chan<- struct{}) { | ||
| func (n *Notifier) AddNode(machineKey string, c chan<- types.StateUpdate) { |
There was a problem hiding this comment.
Here seems to be the MachineKey of the Node.
There was a problem hiding this comment.
We might have nodes with the same machinekey but different nodekeys, right?
12 tasks
|
@vsychov did you try the tests with the route/exit node issue including the last commit? Would you mind opening an issue for that one? I'll have a look at the online status now. |
This was referenced Sep 24, 2023
|
@kradalby , I'll try my tests on current |
2 tasks
|
Problems still appear, I created issue: #1561 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the state management in headscale, instead of relying on timestamps and frequent checking, and sending the entire world every time, we now send incremental updates based on the change that has happened.
Closes #1390
Fixes #1461