Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools to tox.ini #1058

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

Aflynn50
Copy link
Contributor

Description

In python version 12 setuptools in no longer included by default in venv environments as can be seen in the release notes here: https://docs.python.org/3/whatsnew/3.12.html. This is needed for setup.py.

Therefore we have to specify it in the dependencies.

@Aflynn50 Aflynn50 requested a review from cderici May 31, 2024 15:34
@Aflynn50
Copy link
Contributor Author

/merge

In python12 setuptools in no longer included by default in venv
enviroments https://docs.python.org/3/whatsnew/3.12.html

Therefore we have to specify it in the dependencies
@Aflynn50
Copy link
Contributor Author

/merge

@jujubot jujubot merged commit b569634 into juju:master Jun 18, 2024
7 of 9 checks passed
jujubot added a commit that referenced this pull request Jul 11, 2024
#1071

## What's Changed
* fix parsing of storage constraints by @luissimas in #1053
* Add setuptools to tox.ini by @Aflynn50 in #1058
* fix(refresh): bug with revisions by @jack-w-shaw in #1067
* feat: conventional commits static analysis by @SimonRichardson in #1068
* fix(series): add noble support by @jack-w-shaw in #1063
* fix zones constrains list parsing by @luissimas in #1054
* fix(model): fix wrong instanciation of list-secrets facade by @gboutry in #1065
* fix(makefile): run .tox before lint in makefile target by @cderici in #1069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants