fix(series): add noble support #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderici
approved these changes
Jun 26, 2024
jack-w-shaw
force-pushed
the
JUJU-6223_add_noble_support
branch
2 times, most recently
from
9c3fdab
to
95128b8
Compare
Integration test added |
|
/merge |
1 similar comment
|
/merge |
|
Hey guys! is there any ETA for this patch to land ? |
|
/merge |
|
Hm, it looks like merging is still blocked? |
|
@UtkarshBhatthere @sabaini Yeah we're currently working on fixing some trouble with the jenkins job, it should be fixed in a day or two, after that, we're good to go 👍 |
jack-w-shaw
force-pushed
the
JUJU-6223_add_noble_support
branch
from
95128b8
to
cfd6897
Compare
|
/merge |
1 similar comment
|
/merge |
jack-w-shaw
force-pushed
the
JUJU-6223_add_noble_support
branch
from
d46485c
to
d920461
Compare
|
/merge |
The pylibjuju client hardcodes a mapping between series codename and the base channel. Noble was absent from this mapping, meaning pylibjuju doesn't know know to deploy to noble. Add noble to this mapping. After noble, we will only support deploying by base. Noble will be the last series added to this map Add an integration test which deploys a charm to noble
jack-w-shaw
force-pushed
the
JUJU-6223_add_noble_support
branch
from
d920461
to
6bfbe24
Compare
|
/merge |
jujubot
added a commit
that referenced
this pull request
Jul 11, 2024
#1071 ## What's Changed * fix parsing of storage constraints by @luissimas in #1053 * Add setuptools to tox.ini by @Aflynn50 in #1058 * fix(refresh): bug with revisions by @jack-w-shaw in #1067 * feat: conventional commits static analysis by @SimonRichardson in #1068 * fix(series): add noble support by @jack-w-shaw in #1063 * fix zones constrains list parsing by @luissimas in #1054 * fix(model): fix wrong instanciation of list-secrets facade by @gboutry in #1065 * fix(makefile): run .tox before lint in makefile target by @cderici in #1069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pylibjuju client hardcodes a mapping between series codename and the base channel.
Noble was absent from this mapping, meaning pylibjuju doesn't know know to deploy to noble.
Add noble to this mapping.
After noble, we will only support deploying by base. Noble will be the last series added to this map
Fixes: #1062
QA Steps
Download a local charm
juju download ubuntu, unzip, and amend themanifest,yamlto support ubuntu@24.04Place the charm dir at
./ubuntuYou will see
Then:
All CI tests need to pass.