-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix comparison used to determine change in invalidations #20
base: main
Are you sure you want to change the base?
Conversation
Is it really intended to install this workflow by copy pasting the check into every repo that uses it. A bug in that code (which is the case here) means that every single repo has to update their workflow. Shouldn't this be versioned somehow? Anyway, there should probably be some mass action that opens PR to fix all the places where this workflow got added. |
It might be possible to fix the existing actions by being sufficiently clever in updating how these values are stored: julia-invalidations/action.yml Lines 10 to 16 in 5d23709
so that if |
Would changing julia-invalidations/action.yml Lines 61 to 62 in 5d23709
to something like println(io, @sprintf("total=%09d", inv_total)")
println(io, @sprintf("deps=%09d", inv_deps)") do this trick? |
Maybe, I'm not sure exactly how github treats these things so I think it just has to be tested in practice. |
Has that been tried? It'd be good to get this in given maintenance attention on the action right now. |
#4 made the comparison go from a number comparison to a string comparison effectively breaking the workflow.
Fixes #16, #8