Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations do not work in ie11 #885

Open
cenderDA opened this issue Jul 5, 2018 · 13 comments
Open

Animations do not work in ie11 #885

cenderDA opened this issue Jul 5, 2018 · 13 comments

Comments

@cenderDA
Copy link

cenderDA commented Jul 5, 2018

Your system information

  • VelocityJS version: 2.0.5
  • Browser: Internet Explorer 11 (11.371.16299.0)
  • Operating System: Windows 10 Pro Version 1709 (Build: 16299.371)

Checklist

  • Is this an issue with code?: [Yes]
  • Is this an issue with documentation?: [No]
  • Have you reproduced this in other browsers?: [Yes] (Every IE11 we have here has the problem, non-IEs don't have the problem, Edge also works)
  • Have you checked for updates?: [Yes]
  • Have you checked for similar open issues?: [Yes]

Please remember that this is an issue tracker, support requests should be posted on StackOverflow - see CONTRIBUTING.md

Please describe your issue in as much detail as possible:

Describe what you expected should happen and what did happen.

Steps for reproducing this issue (code):

  1. Opening IE 11
  2. Calling a website which includes Velocity.js (without JQuery)
  3. Animations won't work console-Error: "VelocityJS: Error when trying to identify SVG attributes on SVGElement."

JSFiddle example showing issue in action (code):

Go to https://jsfiddle.net/Rycochet/mqv9L27u/ - click the "Fork" button at the top, create the example and copy the new URL back here. -> the Links does not work in ie11 here

@SteadfastCollective
Copy link

Any updates on this issue, still getting issues with it on IE11.

Thanks

@Rycochet
Copy link
Collaborator

I've not got time to do anything on Velocity right now - the issue is (again) IE not following the standards, so some sort of work-around will need to be done. At the least the compatibility layer should be able to manually add the per-Element types as strings rather than dynamically detecting them - however that compatibility layer hasn't been started yet...

@Mandras
Copy link

Mandras commented Nov 26, 2018

Still got the same error

@nicolochiellini
Copy link

Same problem here!
I trusted the text on the website "Velocity works everywhere — back to IE8 and Android 2.3." but is not true!

@Rycochet
Copy link
Collaborator

Rycochet commented Dec 6, 2018

@nicolochiellini So as the huge bold warning at the top of the README states clearly that the old website is not relevant to V2, maybe you'd like to point me at where on GitHub that is so I can fix it...

@Mandras
Copy link

Mandras commented Dec 6, 2018

I made an entire project without jquery and I used velocity
At the end of the project, we had to remove Velocity because it still do not work on IE11, ...
#sad

@pasckosky
Copy link

Looking for the detail of the problem (and trying to find a workaround to have something working) I found this:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol

The Symbol global object is ... simply not supported in IE. Not partially, not bugged ... not at all

Since velocity.js uses it to (as far as I read the generated code) inspect data and do stuff, this means that velocity.js is not compatible at all with any IE.

Right now I am trying to figure out how to provide a quick replacement of (at least) the iterator method of this global object in IE, hoping not to find other surprises about the wierd IE.

@Rycochet
Copy link
Collaborator

Rycochet commented Dec 7, 2018

Ah - that's purely generated, it's not used at all in the source code, so should be something that can be adjusted at compile-time (maybe the babel options or babel / typescript interactions).

@pasckosky
Copy link

Ok. So the JS file was compiled for a standard environment and IE is out of standard.

Since there are other things apart Symbol.iterator that the JS uses (i.e. Object.assign and Object.includes), is there an option to recompile the JS file in a "compatibility" mode? I mean something that is clearly broken, but can work with IE?

In this manner, I can say I can use the good version for all browsers and the "compatible" for the ones that still stick with IE?

Thanks a lot

@Rycochet
Copy link
Collaborator

Rycochet commented Dec 7, 2018

Babel actually supports all of that - possibly just adding IE to the list of supported browsers might get it to do it, though it might need adding a polyfill (part of babel again) to support it (and thank you so much for looking into this, I've really not had any free time for Velocity for months!)

@nicolochiellini
Copy link

@pasckosky has compiled a velocity that run on IE11 with the help of polyfill.
It solved our problem, we had to remove the click event on a SVG and switch to PNG but it works more or less like for the other browsers.
Here is our project
Other browsers:
http://www.aristonthermo.com/greetings/
Working on IE11:
http://www.aristonthermo.com/greetings/ie11-fiocchi.html

@pasckosky will commit the velocity for ie.

For the people who need it ASAP this is a quick link for the two js that run on IE:
https://transfer.sh/VwUpg/velocity_ie.zip

@pasckosky
Copy link

@Rycochet I will try to get a clean set of commit before sending you a pull request.

@lordaplala
Copy link

Any news on this ?

wagich added a commit to wagich/velocity that referenced this issue Nov 30, 2019
arguments can't be properly polyfilled for iteration, so we use the args array (which gets emitted anyway)
Rycochet added a commit that referenced this issue Feb 15, 2020
Minimal fix for #885: Animations don't work in IE11
Rycochet added a commit that referenced this issue Aug 3, 2020
Minimal fix for #885: Animations don't work in IE11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants