-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animations do not work in ie11 #885
Comments
Any updates on this issue, still getting issues with it on IE11. Thanks |
I've not got time to do anything on Velocity right now - the issue is (again) IE not following the standards, so some sort of work-around will need to be done. At the least the compatibility layer should be able to manually add the per-Element types as strings rather than dynamically detecting them - however that compatibility layer hasn't been started yet... |
Still got the same error |
Same problem here! |
@nicolochiellini So as the huge bold warning at the top of the README states clearly that the old website is not relevant to V2, maybe you'd like to point me at where on GitHub that is so I can fix it... |
I made an entire project without jquery and I used velocity |
Looking for the detail of the problem (and trying to find a workaround to have something working) I found this: The Symbol global object is ... simply not supported in IE. Not partially, not bugged ... not at all Since velocity.js uses it to (as far as I read the generated code) inspect data and do stuff, this means that velocity.js is not compatible at all with any IE. Right now I am trying to figure out how to provide a quick replacement of (at least) the iterator method of this global object in IE, hoping not to find other surprises about the wierd IE. |
Ah - that's purely generated, it's not used at all in the source code, so should be something that can be adjusted at compile-time (maybe the babel options or babel / typescript interactions). |
Ok. So the JS file was compiled for a standard environment and IE is out of standard. Since there are other things apart Symbol.iterator that the JS uses (i.e. Object.assign and Object.includes), is there an option to recompile the JS file in a "compatibility" mode? I mean something that is clearly broken, but can work with IE? In this manner, I can say I can use the good version for all browsers and the "compatible" for the ones that still stick with IE? Thanks a lot |
Babel actually supports all of that - possibly just adding IE to the list of supported browsers might get it to do it, though it might need adding a polyfill (part of babel again) to support it (and thank you so much for looking into this, I've really not had any free time for Velocity for months!) |
@pasckosky has compiled a velocity that run on IE11 with the help of polyfill. @pasckosky will commit the velocity for ie. For the people who need it ASAP this is a quick link for the two js that run on IE: |
@Rycochet I will try to get a clean set of commit before sending you a pull request. |
Any news on this ? |
arguments can't be properly polyfilled for iteration, so we use the args array (which gets emitted anyway)
Minimal fix for #885: Animations don't work in IE11
Minimal fix for #885: Animations don't work in IE11
Your system information
Checklist
Please describe your issue in as much detail as possible:
Describe what you expected should happen and what did happen.
Steps for reproducing this issue (code):
JSFiddle example showing issue in action (code):
The text was updated successfully, but these errors were encountered: