Minimal fix for #885: Animations don't work in IE11 #914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Animations do not work in ie11 #885
Yes, I agree
Please describe this Pull Request in as much detail as possible:
As stated in #885, there is a problem running animations in IE11. I traced it to the utility function
getValue
, which tries to iteratearguments
. This works in browsers with proper iterator support, but falls apart otherwise. The problem lies inarguments
being of typeobject
and notarray
so we can't really polyfill it (see babel/babel#1181).With this PR, the
args
variable is iterated instead, since it is a proper array and can be polyfilled. Theargs
-array is created and filled anywayvelocity/velocity.es5.js
Lines 150 to 152 in e238e87
People who contributed to this change:
Michael Wagner