useSessionStorage improvements #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which happen when session storage is updated for a different key.
sskirby
force-pushed
the
useSessionStorage-improvements
branch
from
ada583f to
1266f5b
Compare
sskirby
commented
Jan 11, 2023
| } | ||
| }, [initialValue, key]) | ||
|
|
||
| // State to store our value | ||
| // Pass initial state function to useState so logic is only executed once | ||
| const [storedValue, setStoredValue] = useState<T>(readValue) | ||
| // create a new empty object to keep track of the identity of the hook | ||
| const [source] = useState({}) |
There was a problem hiding this comment.
@juliencrn do you think it worthwhile to extract the creation of the empty object into a function so that it isn't created on each render?
sskirby
force-pushed
the
useSessionStorage-improvements
branch
from
1266f5b to
3b72152
Compare
sskirby
commented
Jan 11, 2023
Comment on lines
+26
to
+27
| const getInitialValue = () => | ||
| initialValue instanceof Function ? initialValue() : initialValue |
There was a problem hiding this comment.
@juliencrn or maybe memo-ize the initialValue so that we guarantee it only ever gets evaluated once?
juliencrn
added a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 3 changes for the
useSessionStoragehook:I love the library! Please let me know how I can improve the PR for your approval!