Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useReadLocalStorage: localStorage failing to parse when not JSON #426

Closed
wants to merge 1 commit into from

Conversation

nateforsyth
Copy link

I've updated useReadLocalStorage to attempt to return T after failing to parse JSON when localStorage values aren't stored as JSON.

Console output.
image

Debug, plain string localStorage item.
image

Error handler.
image

…rse JSON when localStorage values aren't stored as JSON.
Copy link

changeset-bot bot commented Jan 17, 2024

⚠️ No Changeset found

Latest commit: a09f734

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliencrn juliencrn added the bug Something isn't working label Jan 19, 2024
@juliencrn
Copy link
Owner

Should be fixed by #439

@juliencrn juliencrn closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants