Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useReadLocalStorage: localStorage failing to parse when not JSON #426

Closed
wants to merge 1 commit into from
Closed

useReadLocalStorage: localStorage failing to parse when not JSON #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions packages/usehooks-ts/src/useReadLocalStorage/useReadLocalStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,32 @@ export function useReadLocalStorage<T>(key: string): Value<T> {
return null
}

let item: string | null = ""

try {
const item = window.localStorage.getItem(key)
return item ? (JSON.parse(item) as T) : null
} catch (error) {
item = window.localStorage.getItem(key)
}
catch (error) {
console.warn(`Error reading localStorage key “${key}”:`, error)
return null
}

// try parse as JSON
try {
return item ? (JSON.parse(item) as T) : null
}
catch (error) {
console.warn(`Error parsing JSON key “${key}”, item “${item}”:`, error)
}

// try return as T
try {
return item ? item as T : null
}
catch (error) {
console.warn(`Error returning Generic item at key “${key}”:`, error)
return null
}
}, [key])

// State to store our value
Expand Down