-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Remove deprecated hooks and co #503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: edd3814 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Before v3 remember to merge the automated workflow PR. |
juliencrn
changed the title
Remove deprecated hooks and co
🔥 Remove deprecated hooks and co
Feb 22, 2024
juliencrn
added a commit
that referenced
this pull request
Feb 27, 2024
* Remove @deprecated hooks' function overload keeping the latest signature only * Remove @deprecated hooks only keeping updated version of their .md doc files * Remove deprecated hook exclusions in scripts + little clean up * website: allow hook without code nor demo wheneven there is a .md file * 🔖 Add changeset
juliencrn
added a commit
that referenced
this pull request
Mar 4, 2024
* Remove @deprecated hooks' function overload keeping the latest signature only * Remove @deprecated hooks only keeping updated version of their .md doc files * Remove deprecated hook exclusions in scripts + little clean up * website: allow hook without code nor demo wheneven there is a .md file * 🔖 Add changeset
juliencrn
added a commit
that referenced
this pull request
Mar 5, 2024
* Remove @deprecated hooks' function overload keeping the latest signature only * Remove @deprecated hooks only keeping updated version of their .md doc files * Remove deprecated hook exclusions in scripts + little clean up * website: allow hook without code nor demo wheneven there is a .md file * 🔖 Add changeset
juliencrn
added a commit
that referenced
this pull request
Mar 8, 2024
* 🏗️ Move the full workspace to ES Module (#502) * 🔥 Remove deprecated hooks and co (#503) * ♻️ Prefer type over interface (#515) * ♻️ Generate documentation from JSDoc using typedoc (#519) * 📝 Fix documentation build with some little improvements * 👷 Add "DOM.Iterable" as the code runs in the DOM * 📝 Add Algolia doc search command menu (#513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the major release to batch all breaking changes in the hooks.
This PR removes previously deprecated hooks and old hooks' signatures.
Removed
useDebounce
: Replaced by bothuseDebouceValue
anduseDebounceCallback
.useEffectOnce
: unnecessary abstraction.useElementSize
: Replaced by more performantuseResizeObserver
.useFetch
: Prefer RSC, framework methods, React'suse
, React-query, useSWR...useImageOnLoad
: Too opinionated.useIsFirstRender
: Not comply with the React functional mindset (cf: React 18 render twice in strict mode).useLockedBody
: Replaced by the more genericuseScrollLock
.useSsr
: It was not a React hook, other hooks can do the job.useUpdateEffect
: unnecessary abstraction.Hooks with dropped legacy signature
useCountDown
useDarkMode
useIntersectionObserver
useMediaQuery
useTernaryDarkMode
Additional
Also updated the website to allow hook pages without
code
ordemo
. Later, we could consider removing the doc for removed hooks and use permanent redirection to the alternative.