Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactor/prefer type over interface #515

Merged
merged 1 commit into from
Feb 27, 2024
Merged

♻️ Refactor/prefer type over interface #515

merged 1 commit into from
Feb 27, 2024

Conversation

juliencrn
Copy link
Owner

No description provided.

@juliencrn juliencrn added the V3 Something introduces breaking changes. label Feb 27, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2024

⚠️ No Changeset found

Latest commit: 17bd9c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliencrn juliencrn merged commit 22fde74 into v3 Feb 27, 2024
2 checks passed
juliencrn added a commit that referenced this pull request Feb 27, 2024
@juliencrn
♻️ Prefer type over interface (#515)
072b7e6
juliencrn added a commit that referenced this pull request Mar 4, 2024
@juliencrn
♻️ Prefer type over interface (#515)
dda52f7
juliencrn added a commit that referenced this pull request Mar 5, 2024
@juliencrn
♻️ Prefer type over interface (#515)
c4e8f02
juliencrn added a commit that referenced this pull request Mar 8, 2024
@juliencrn
🚀 V3 (#514)
a8e8968 
* 🏗️ Move the full workspace to ES Module (#502)

* 🔥 Remove deprecated hooks and co (#503)

* ♻️ Prefer type over interface (#515)

* ♻️ Generate documentation from JSDoc using typedoc (#519)

* 📝 Fix documentation build with some little improvements

* 👷 Add "DOM.Iterable" as the code runs in the DOM

* 📝 Add Algolia doc search command menu (#513)
@adidahiya
Copy link

@juliencrn what was the motivation for this change? Just curious.

@juliencrn
Copy link
Owner Author

@juliencrn what was the motivation for this change? Just curious.

Hi, initially, I was looking for uniformization as we used both interchangeably. We opted for type to reduce possible weird behavior, which is explained here: https://www.youtube.com/watch?v=zM9UPcIyyhQ. It's not very important though

@adidahiya
Copy link

@juliencrn thanks for the video link, that was an interesting watch.

It looks like you're a solo maintainer of this project, so PR documentation might not be a top priority for you (I've been in the same position), but as a user of the library and watcher on Github, I would love it if your PRs had non-empty descriptions so that I could keep track of changes a little better :) thanks

@EchoSkorJjj EchoSkorJjj mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
V3 Something introduces breaking changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliencrn @adidahiya