initial implementation of new default solvers; passing on Julia 0.6 #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
+ Coverage 87.79% 90.02% +2.23%
==========================================
Files 18 18
Lines 4513 4854 +341
==========================================
+ Hits 3962 4370 +408
+ Misses 551 484 -67
Continue to review full report at Codecov.
|
|
And we have tests passing on 0.6! |
|
@joehuchette, any objection to merging this and bikeshedding and documenting the default solver stuff in a separate PR? |
mlubin
changed the title
joehuchette
reviewed
Feb 15, 2017
src/solvers.jl
Outdated
| solvers = Symbol(solvertype*"solvers") | ||
| functionname = Symbol("default"*solvertype*"solver") | ||
| if VERSION > v"0.6.0-" | ||
| @eval function ($functionname)() |
There was a problem hiding this comment.
Indentation here is confusing
joehuchette
reviewed
Feb 15, 2017
| if VERSION < v"0.6.0-dev" | ||
| @objective(mod, Max, obj[1]) | ||
| else | ||
| @objective(mod, Max, obj) |
There was a problem hiding this comment.
Vector transposes are taken seriously now
joehuchette
reviewed
Feb 15, 2017
| @constraint(m, x'*A*x .>= 1) | ||
| else | ||
| # force vector output | ||
| @constraint(m, reshape(x,(1,3))*A*x .>= 1) |
There was a problem hiding this comment.
It's just to test the vector pathway.
|
No objections, looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default solver stuff needs to be tidied up (docs and examples), but this should now be passing on 0.6.