Floating Windows Support VIM Popup #821

blayz3r · 2019-06-06T21:23:19Z

Category
- Question
- Bug
- Suggestion
OS
- Linux
- macOS
- Windows
- Etc.
Vim
- Vim
- Neovim

Does the new VIM popup feature enable FZF to float in VIM

junegunn · 2019-06-08T14:38:04Z

the new VIM popup feature

If floating windows of Neovim is what you meant, see #664.

blayz3r · 2019-06-08T15:49:21Z

I meant Vim proper. Can the same be achieved with Vim's Popup feature?

junegunn · 2019-06-08T15:51:12Z

I don't know about "the new VIM popup feature". Can you explain what it is? Any reference?

blayz3r · 2019-06-08T16:14:36Z

There was discussion here vim/vim#4063 and possible with use with FZF like plugins here vim/vim#4063 (comment)

dkarter · 2019-08-02T19:26:42Z

@junegunn it looks something like this:

It is supported in both NeoVim and Vim.

Plugins such as denite.nvim, coc.nvim, vimgon-quest-menu, etc have already implemented it if you are curious to see how it's done.

blayz3r · 2019-10-06T16:12:11Z

like liuchengxu/vim-clap

dkarter · 2019-10-07T00:19:00Z

for those of you who are still looking, check out this config from the creator of FZF (@junegunn): https://github.com/junegunn/dotfiles/commit/9545174d0e34075d16c1d6a01eed820bce9d6cc0

tracyone · 2019-10-07T00:34:28Z

@dkarter

    if has('nvim') && exists('&winblend') && &termguicolors

Only for neovim, but we want vim too

dkarter · 2019-10-07T01:33:12Z

Right. Didn't realize that - my bad.

dpretet · 2019-10-10T19:29:47Z

Would love to this setup/feature possible with Vim8! Any news?

runar · 2019-10-27T19:20:58Z

I spent a few hours on this today, but ended up with nothing: The results from fzf is printed in the background with the popup (floating window) hovering on top of it. I couldn’t get the result to fill the popup, so it seems I’ll have to leave this to someone more experienced than myself.

dpretet · 2019-10-27T19:24:23Z

@runar can you share your code please? I don’t have so much experience on vim plugin but if I can help :)

runar · 2019-10-27T19:37:55Z

@damofthemoon There’s not really any code to share, as all I did was read the Vim documentation on popup windows and try to convert this function to use popup_create().

I don’t understand what the second parameter (call FloatingFZF()) of the below line should be. Is it expecting a window id or buffer number, or a window or buffer instance? What should FloatingFZF() return for this to work?

let g:fzf_layout = { 'window': 'call FloatingFZF()’ }

dpretet · 2019-10-28T20:38:33Z

No better result than you @runar... I can't figure out how it could work for Vim8, I suspect Nvim handles differently pop-up feature 🤔

runar · 2019-11-29T06:36:09Z

@lightalchemist I'm aware of that, which is why I’m referencing the same commit (where FloatingFZF() is defined) as you do. The problem, as I wrote in my post, is that I’m unable to rewrite the function to make it work for Vim.

What I don't know, is what kind of values g:fzf_layout expects. The first one should be window, but what kind of value is expected where call FloatingFZF() is used? A window id? Buffer number? Or a window or buffer instance? I’ve tried them all without success.

junegunn · 2019-11-29T06:44:46Z

@runar Please read through https://github.com/junegunn/fzf/blob/master/README-VIM.md

runar · 2019-11-29T08:00:20Z

@junegunn Just what I needed, thank you! I will take a new look at this later.

dpretet · 2019-11-29T16:02:01Z

I can only create a popup with Vim8 but not fill it with FZF output. Another thing disturbing me is the popup needs to be clear with popup_clear() function, it doesn't disappear automatically. Can we access a kind of callback to clean that @junegunn? Any idea why we can't fill the popup with FZF?

junegunn · 2019-12-02T03:24:44Z

I'm a Neovim user, and I have no experience with Vim popups. You might want to read the linked issue above.

vim/vim#4063 (comment)

Bram doesn't seem to understand why we want to open a terminal buffer (running fzf) inside a popup window.

dpretet · 2019-12-02T08:47:55Z

Thanks for pointing this problem @junegunn, now I understand the problem better. I see in the issue tracking a solution could exist but it sounds to me tricky while it's simple to open FZF in a pane (I did try with let g:fzf_layout = { 'window': 'vs' } and it works like a charm). Maybe that's a good opportunity to switch to Neovim 🤓.

blayz3r · 2019-12-04T01:57:32Z

Yggdroot/LeaderF and liuchengxu/vim-clap have workarounds

junegunn · 2019-12-04T02:07:00Z

@blayz3r They are native Vim plugins unlike fzf, so they don't have the problem.

blayz3r · 2020-02-01T23:14:51Z

vim/vim@219c7d0

lacygoill · 2020-02-03T07:22:11Z

FWIW, this seems to make fzf display its terminal buffer in a Vim popup window:

fu s:snr() abort
    return matchstr(expand('<sfile>'), '.*\zs<SNR>\d\+_')
endfu
let s:snr = get(s:, 'snr', s:snr())
let g:fzf_layout = {'window': 'call '..s:snr..'fzf_window(0.9, 0.6, "Comment")'}

fu s:fzf_window(width, height, border_highlight) abort
    let width = float2nr(&columns * a:width)
    let height = float2nr(&lines * a:height)
    let row = float2nr((&lines - height) / 2)
    let col = float2nr((&columns - width) / 2)
    let top = '┌' . repeat('─', width - 2) . '┐'
    let mid = '│' . repeat(' ', width - 2) . '│'
    let bot = '└' . repeat('─', width - 2) . '┘'
    let border = [top] + repeat([mid], height - 2) + [bot]
    let frame = s:create_popup_window(a:border_highlight, {
        \ 'line': row,
        \ 'col': col,
        \ 'width': width,
        \ 'height': height,
        \ 'is_frame': 1,
        \ })
    call setbufline(frame, 1, border)
    call s:create_popup_window('Normal', {
        \ 'line': row + 1,
        \ 'col': col + 2,
        \ 'width': width - 4,
        \ 'height': height - 2,
        \ })
endfu

fu s:create_popup_window(hl, opts) abort
    if has_key(a:opts, 'is_frame')
        let id = popup_create('', #{
            \ line: a:opts.line,
            \ col: a:opts.col,
            \ minwidth: a:opts.width,
            \ minheight: a:opts.height,
            \ zindex: 50,
            \ })
        call setwinvar(id, '&wincolor', a:hl)
        exe 'au BufWipeout * ++once call popup_close('..id..')'
        return winbufnr(id)
    else
        let buf = term_start(&shell, #{hidden: 1})
        call popup_create(buf, #{
            \ line: a:opts.line,
            \ col: a:opts.col,
            \ minwidth: a:opts.width,
            \ minheight: a:opts.height,
            \ zindex: 51,
            \ })
        exe 'au BufWipeout * ++once bw! '..buf
    endif
endfu

The code is similar to the one for Nvim documented in the wiki. You can configure the width and the height of the window (as a percentage of the total width/height available), as well as the color of the border, by changing the arguments passed to s:fzf_window():

let g:fzf_layout = {'window': 'call '..s:snr..'fzf_window(0.9, 0.6, "Comment")'}
                                                          │    │     │
                                                          │    │     └ border's highlight group
                                                          │    └ height
                                                          └ width

To support both Vim and Neovim:

fu s:snr() abort
    return matchstr(expand('<sfile>'), '.*\zs<SNR>\d\+_')
endfu
let s:snr = get(s:, 'snr', s:snr())
let g:fzf_layout = {'window': 'call '..s:snr..'fzf_window(0.9, 0.6, "Comment")'}

fu s:fzf_window(width, height, border_highlight) abort
    let width = float2nr(&columns * a:width)
    let height = float2nr(&lines * a:height)
    let row = float2nr((&lines - height) / 2)
    let col = float2nr((&columns - width) / 2)
    let top = '┌' . repeat('─', width - 2) . '┐'
    let mid = '│' . repeat(' ', width - 2) . '│'
    let bot = '└' . repeat('─', width - 2) . '┘'
    let border = [top] + repeat([mid], height - 2) + [bot]
    if has('nvim')
        let frame = s:create_float(a:border_highlight, {
            \ 'row': row,
            \ 'col': col,
            \ 'width': width,
            \ 'height': height,
            \ })
        call nvim_buf_set_lines(frame, 0, -1, v:true, border)
        call s:create_float('Normal', {
            \ 'row': row + 1,
            \ 'col': col + 2,
            \ 'width': width - 4,
            \ 'height': height - 2,
            \ })
        exe 'au BufWipeout <buffer> bw '..frame
    else
        let frame = s:create_popup_window(a:border_highlight, {
            \ 'line': row,
            \ 'col': col,
            \ 'width': width,
            \ 'height': height,
            \ 'is_frame': 1,
            \ })
        call setbufline(frame, 1, border)
        call s:create_popup_window('Normal', {
            \ 'line': row + 1,
            \ 'col': col + 2,
            \ 'width': width - 4,
            \ 'height': height - 2,
            \ })
    endif
endfu

fu s:create_float(hl, opts) abort
    let buf = nvim_create_buf(v:false, v:true)
    let opts = extend({'relative': 'editor', 'style': 'minimal'}, a:opts)
    let win = nvim_open_win(buf, v:true, opts)
    call setwinvar(win, '&winhighlight', 'NormalFloat:'..a:hl)
    return buf
endfu

fu s:create_popup_window(hl, opts) abort
    if has_key(a:opts, 'is_frame')
        let id = popup_create('', #{
            \ line: a:opts.line,
            \ col: a:opts.col,
            \ minwidth: a:opts.width,
            \ minheight: a:opts.height,
            \ zindex: 50,
            \ })
        call setwinvar(id, '&wincolor', a:hl)
        exe 'au BufWipeout * ++once call popup_close('..id..')'
        return winbufnr(id)
    else
        let buf = term_start(&shell, #{hidden: 1})
        call popup_create(buf, #{
            \ line: a:opts.line,
            \ col: a:opts.col,
            \ minwidth: a:opts.width,
            \ minheight: a:opts.height,
            \ zindex: 51,
            \ })
        exe 'au BufWipeout * ++once bw! '..buf
    endif
endfu

If I find issues, I'll try to fix them here and here.

blayz3r · 2020-02-03T07:27:42Z

@lacygoill Excellent works flawlessly

junegunn · 2020-02-03T08:29:55Z

@lacygoill Thanks, I'll consider adding that to the main fzf repo so anyone can easily use it.

@lacygoill

e.g. let g:fzf_layout = { 'window': { 'width': 0.9, 'height': 0.6 } } Based on the code from junegunn/fzf.vim#821 (comment) by @lacygoill.

junegunn · 2020-02-03T15:53:49Z

Popup support added in junegunn/fzf@7ceb58b.

let g:fzf_layout = { 'window': { 'width': 0.9, 'height': 0.6 } }

" Border color
let g:fzf_layout = { 'window': { 'width': 0.9, 'height': 0.6, 'highlight': 'Todo' } }

" Border style (rounded / sharp / horizontal)
let g:fzf_layout = { 'window': { 'width': 0.9, 'height': 0.6, 'highlight': 'Todo', 'border': 'sharp' } }

Works for me fine both on Vim and Neovim. 😄

junegunn/fzf.vim#821

jesseleite · 2020-02-03T22:28:36Z

Is it still possible to align the fzf results at the bottom, but still as a popup to prevent fzf from pushing the active buffer upwards off the screen?

mhanberg · 2020-02-04T00:01:15Z

@junegunn will you be releasing a new version of fzf soon so I can take advantage of this behavior? I use fzf through homebrew.

Thanks!

junegunn · 2020-02-04T02:09:32Z

@mhanberg Yes, I will. But there are some nice stuff on the review queue that I'd like to include in the next release, so it will take a few more days. You might already know this, but you can still use the latest vim plugin of fzf even if you installed the binary via Homebrew. Plug 'junegunn/fzf' will make vim-plug clone the main fzf repo on a separate directory and load the vim plugin file from there while using the binary on $PATH. You might want to take a look at the updated installation instruction which hopefully clears up some confusion: https://github.com/junegunn/fzf.vim#installation

@jesseleite While the above dictionary form ({ 'window': { ... } }) currently doesn't support options for positioning the window, you can still write a function that does that and use it as the layout. But yeah, it's a bit of a hassle, do you have any suggestions? Would yoffset suffice?

097115 · 2020-02-04T05:58:58Z

@junegunn, if you don't mind, I'm not exactly getting why fzf ships with some additional Vim plugin? Why fzf.vim is not enough, is not the only place for al the Vim-related stuff?

Just trying to clarify the structure in my head :)

Thanks.

henrebotha · 2020-02-04T08:29:54Z

The new feature crashed my machine before I updated my Vim to 8.2. I think a feature guard of some description is in order!

rogchap · 2020-02-04T10:04:48Z

I have a local fzf#run() is there a way to get this to except the window dictionary for it's layout?
eg:

 fzf#run({'source': l:mysource, 'sink': function("mysink"), 'window': { ... } })

ghost · 2020-02-04T11:25:36Z

How to make it float relative to the current buffer/window rather than the entire editor?

mhanberg · 2020-02-04T17:45:02Z

I am able to get this to work in NeoVim, but when using Vim I run into the following error when calling :Files. (I use NeoVim in the terminal, but prefer to use MacVim for normal usage).

The following was produced using the current Vim as installed by Homebrew (MacVim is not updated as of yet).

Screenshot

GIF of the error

Any ideas? Thanks!

This is the fzf configuration that I use

" .vimrc
function! RipgrepFzf(query, fullscreen)
  let command_fmt = 'rg --column --line-number --no-heading --color=always --smart-case %s || true'
  let initial_command = printf(command_fmt, shellescape(a:query))
  let reload_command = printf(command_fmt, '{q}')
  let spec = {'options': ['--phony', '--query', a:query, '--bind', 'change:reload:'.reload_command], 'window': { 'width': 0.9, 'height': 0.6 }}
  call fzf#vim#grep(initial_command, 1, fzf#vim#with_preview(spec), a:fullscreen)
endfunction

command! -nargs=* -bang RG call RipgrepFzf(<q-args>, <bang>0)

silent! nnoremap <c-p> :Files<cr>
nnoremap gl :BLines<cr>
nnoremap <leader>a :RG<cr>

let g:fzf_layout = { 'window': { 'width': 0.5, 'height': 0.6 } }

# .zshrc
export FZF_DEFAULT_COMMAND="rg --files --hidden --glob '!.git/'"

Vim Version

⚡︎/usr/local/bin/vim --version
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Feb  3 2020 01:40:55)
macOS version
Included patches: 1-200
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl               -farsi             -mouse_sysmouse    -tag_old_static
+arabic            +file_in_path      +mouse_urxvt       -tag_any_white
+autocmd           +find_in_path      +mouse_xterm       -tcl
+autochdir         +float             +multi_byte        +termguicolors
-autoservername    +folding           +multi_lang        +terminal
-balloon_eval      -footer            -mzscheme          +terminfo
+balloon_eval_term +fork()            +netbeans_intg     +termresponse
-browse            +gettext           +num64             +textobjects
++builtin_terms    -hangul_input      +packages          +textprop
+byte_offset       +iconv             +path_extra        +timers
+channel           +insert_expand     +perl              +title
+cindent           +job               +persistent_undo   -toolbar
-clientserver      +jumplist          +popupwin          +user_commands
+clipboard         +keymap            +postscript        +vartabs
+cmdline_compl     +lambda            +printer           +vertsplit
+cmdline_hist      +langmap           +profile           +virtualedit
+cmdline_info      +libcall           -python            +visual
+comments          +linebreak         +python3           +visualextra
+conceal           +lispindent        +quickfix          +viminfo
+cryptv            +listcmds          +reltime           +vreplace
+cscope            +localmap          +rightleft         +wildignore
+cursorbind        +lua               +ruby              +wildmenu
+cursorshape       +menu              +scrollbind        +windows
+dialog_con        +mksession         +signs             +writebackup
+diff              +modify_fname      +smartindent       -X11
+digraphs          +mouse             -sound             -xfontset
-dnd               -mouseshape        +spell             -xim
-ebcdic            +mouse_dec         +startuptime       -xpm
+emacs_tags        -mouse_gpm         +statusline        -xsmp
+eval              -mouse_jsbterm     -sun_workshop      -xterm_clipboard
+ex_extra          +mouse_netterm     +syntax            -xterm_save
+extra_search      +mouse_sgr         +tag_binary
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X -DMACOS_X_DARWIN  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector-strong -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/openssl@1.1/lib -L/usr/local/opt/readline/lib  -L/usr/local/lib -o vim        -lncurses -liconv -lintl -framework AppKit  -L/usr/local/opt/lua/lib -llua5.3 -mmacosx-version-min=10.15 -fstack-protector-strong -L/usr/local/lib  -L/usr/local/Cellar/perl/5.30.1/lib/perl5/5.30.1/darwin-thread-multi-2level/CORE -lperl -lm -lutil -lc  -L/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/config-3.7m-darwin -lpython3.7m -framework CoreFoundation  -lruby.2.6

ardenzhan · 2020-02-04T17:59:17Z

@mhanberg I have the same problem. Workaround for me is to do :set hidden. Which I found by doing :h E948 and then following the link for |abandon|. I haven't read enough of the manual / debugged further to figure out what the actual problem is though.

junegunn · 2020-02-05T01:39:44Z

@mhanberg @ardenzhan Added junegunn/fzf@0896036 to workaround the issue.

bluz71 · 2020-02-05T02:17:50Z

@junegunn,

Your latest commits fix the issue (at least for me). I had the same error as @mhanberg, but now resolved. Many thanks.

mhanberg · 2020-02-05T02:44:22Z

@junegunn thank you! That solves the problem for me as well.

josefson · 2020-02-11T18:43:54Z

I have just tried this feature, but under vim 8.2 it's thowing me this error where it's trying to open a shell in the popup window when trying any Fzf command.

It actually opens the popup blank and the shells as buffers

mhanberg · 2020-02-11T18:45:51Z

@josefson make sure you have this patch vim/vim@3c01c4a

Repository owner deleted a comment from srijanshetty Nov 29, 2019

junegunn pinned this issue Dec 15, 2019

liuchengxu mentioned this issue Dec 17, 2019

Performance profile liuchengxu/vim-clap#140

Closed

4 tasks

blayz3r closed this as completed Feb 3, 2020

junegunn added a commit to junegunn/fzf that referenced this issue Feb 3, 2020

[vim] Popup window support for both Vim and Neovim

7ceb58b

e.g. let g:fzf_layout = { 'window': { 'width': 0.9, 'height': 0.6 } } Based on the code from junegunn/fzf.vim#821 (comment) by @lacygoill.

evantravers added a commit to evantravers/dotfiles that referenced this issue Feb 3, 2020

Add floating window layout for fzf

8ed1f1e

junegunn/fzf.vim#821

jesseleite mentioned this issue Feb 4, 2020

Non-popup floating/overlay support? #942

Closed

4 tasks

jesseleite mentioned this issue Feb 6, 2020

Floating windows not respecting g:fzf_colors? junegunn/fzf#1858

Closed

10 tasks

junegunn unpinned this issue Feb 9, 2020

lacygoill mentioned this issue Mar 17, 2020

Terminal Popup overflows vim/vim#5802

Closed

lacygoill mentioned this issue May 15, 2020

Options altered in Vim window after using popup junegunn/fzf#2041

Closed

10 tasks

prabirshrestha mentioned this issue Jun 25, 2020

add support for floating window and popup vim-jp/vital.vim#747

Open

nickjj mentioned this issue Aug 7, 2020

Use Vim8.1 popup feature rhysd/git-messenger.vim#30

Open

Floating Windows Support VIM Popup #821

Floating Windows Support VIM Popup #821

Comments

blayz3r commented Jun 6, 2019

junegunn commented Jun 8, 2019

blayz3r commented Jun 8, 2019

junegunn commented Jun 8, 2019 • edited Loading

blayz3r commented Jun 8, 2019

dkarter commented Aug 2, 2019

blayz3r commented Oct 6, 2019

dkarter commented Oct 7, 2019

tracyone commented Oct 7, 2019

dkarter commented Oct 7, 2019

dpretet commented Oct 10, 2019

runar commented Oct 27, 2019

dpretet commented Oct 27, 2019

runar commented Oct 27, 2019

dpretet commented Oct 28, 2019

runar commented Nov 29, 2019

junegunn commented Nov 29, 2019

runar commented Nov 29, 2019

dpretet commented Nov 29, 2019

junegunn commented Dec 2, 2019

dpretet commented Dec 2, 2019

blayz3r commented Dec 4, 2019 • edited Loading

junegunn commented Dec 4, 2019

blayz3r commented Feb 1, 2020

lacygoill commented Feb 3, 2020 • edited Loading

blayz3r commented Feb 3, 2020

junegunn commented Feb 3, 2020 • edited Loading

junegunn commented Feb 3, 2020 • edited Loading

jesseleite commented Feb 3, 2020

mhanberg commented Feb 4, 2020

junegunn commented Feb 4, 2020 • edited Loading

097115 commented Feb 4, 2020

henrebotha commented Feb 4, 2020

rogchap commented Feb 4, 2020

ghost commented Feb 4, 2020

mhanberg commented Feb 4, 2020

ardenzhan commented Feb 4, 2020

junegunn commented Feb 5, 2020

bluz71 commented Feb 5, 2020

mhanberg commented Feb 5, 2020

josefson commented Feb 11, 2020

mhanberg commented Feb 11, 2020

junegunn commented Jun 8, 2019 •

edited

Loading

blayz3r commented Dec 4, 2019 •

edited

Loading

lacygoill commented Feb 3, 2020 •

edited

Loading

junegunn commented Feb 3, 2020 •

edited

Loading

junegunn commented Feb 3, 2020 •

edited

Loading

junegunn commented Feb 4, 2020 •

edited

Loading