Non-popup floating/overlay support?

[jesseleite]

• I have read through https://github.com/junegunn/fzf.vim/blob/master/README.md
• I have read through https://github.com/junegunn/fzf/blob/master/README-VIM.md
• I have read through the manual page of fzf (man fzf)
• I have searched through the existing issues

Now that we have floating popup window support (thank you! 🎉), I'm wondering if it's possible to add a floating option to the default non-floating-window mode. What I mean by this is, I still prefer everything about how the default non-floating-window looks (position, border, etc.), but have always disliked how it pushes buffer content up off the top of the screen, ie)

Given the recent popup window improvements, would it now be possible to have fzf float/overlay the buffer content at the bottom of a window, without pushing it up?

[junegunn]

Added xoffset (0 ~ 1), yoffset (0 ~ 1), and border (rounded | sharp | horizontal) options.

let g:fzf_layout = { 'window': { 'width': 1, 'height': 0.4, 'yoffset': 1, 'border': 'horizontal' } }

[jesseleite]

@junegunn wicked, this is wonderful, thank you 🎉

Now I'm wondering about some sort of top only border option? Would be nice to remove the bottom border line completely, moving the fzf results down one line, if that makes sense...

What are your thoughts on this?

[junegunn]

Well, I'd not like to end up with too many options. Can you try it as it is now for a while and see if you can get used to it?

[jesseleite]

@junegunn totally trying it out. I just think on a bottom panel, a bottom border is a wasted line, and doesn't really make sense. Like if you use some sort of side panel like NerdTree, TagBar, or even your Peekaboo plugin, there will be a border on the inside edge, but not on the outside edge. Likewise with borders between Vim windows, but not outside of Vim windows. Nawmean?

[junegunn]

I realized more options can be useful when you want to launch fzf as a sidebar. So here it is: junegunn/fzf@4fb410a

[jesseleite]

Yassssss. This is 🔥, thank you so much @junegunn ❤️

[poetaman]

@junegunn Is it possible to open a floating fzf window at lower end of current split?

[junegunn]

See junegunn/fzf@8b0e1f9

[poetaman]

@junegunn I get some weird error (happens only with neovim), whenever I run FZF from a split. It does not happen with vim.

The steps to reproduce this error: set the fzf_layout to window-relative (in .vimrc, the one you pointed me to), reopen vim, create some splits and run :FZF.

Update: Actually the error happens in neovim even if I don't set fzf_layout. All that is needed is to have a few splits open... before running FZF

Error detected while processing function <SNR>84_dopopd:
line   20:
E716: Key not present in Dictionary: "dir && (!&autochdir || w:fzf_pushd.bufname ==# bufname(''))"
Press ENTER or type command to continue
Error detected while processing function <SNR>84_dopopd:
line   20:
E15: Invalid expression: s:fzf_getcwd() ==# w:fzf_pushd.dir && (!&autochdir || w:fzf_pushd.bufname ==# bufname(''))
Press ENTER or type command to continue
Error detected while processing function 25[29]..<SNR>84_pushd:
line   10:
E121: Undefined variable: w:fzf_pushd
Press ENTER or type command to continue
Error detected while processing function 25[29]..<SNR>84_pushd:
line   11:
E121: Undefined variable: w:fzf_pushd
Press ENTER or type command to continue
Error detected while processing function 25[29]..<SNR>84_pushd:
line   11:
E15: Invalid expression: w:fzf_pushd
Press ENTER or type command to continue