Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Delete classes that are deprecated for six years." #977

Closed
wants to merge 2 commits into from
Closed

Revert "Delete classes that are deprecated for six years." #977

wants to merge 2 commits into from

Conversation

stefanbirkner
Copy link
Contributor

This reverts commit 745ca05. The
deletion of the classes causes some problems for users (see
https://groups.yahoo.com/neo/groups/junit/conversations/topics/24572).

This revert is independent from #749. #749 was fixed by 88f7a12.

@stefanbirkner
Revert "Delete classes that are deprecated for six years."
6408770 
This reverts commit 745ca05. The
deletion of the classes causes some problems for users (see
https://groups.yahoo.com/neo/groups/junit/conversations/topics/24572).
@stefanbirkner stefanbirkner added this to the 4.12 milestone Aug 13, 2014
@stefanbirkner
Remove f prefix from fields.
e362c19 
This is a follow-up to df00d5e, because this classes have been removed
before this commit. Now the new coding style is applied because we
restored the classes with commit 6408770.
kcooney
kcooney reviewed Aug 14, 2014
View reviewed changes
src/main/java/org/junit/internal/runners/ClassRoadie.java
runnable.run();
}

;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this there originally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I just used git revert

@marcphilipp marcphilipp modified the milestones: 4.13, 4.12 Sep 6, 2014
@marcphilipp
Copy link
Member

We also need to remove the corresponding section from the release notes:
https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md#pull-request-862-delete-classes-that-are-deprecated-for-six-years

@marcphilipp marcphilipp mentioned this pull request Sep 12, 2014
Merged
@marcphilipp
Copy link
Member

Closing in favor of #988.

@marcphilipp marcphilipp removed this from the 4.12 milestone Sep 12, 2014
@stefanbirkner stefanbirkner deleted the revert-gh862 branch November 13, 2014 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanbirkner @marcphilipp @kcooney