Revert "Delete classes that are deprecated for six years." #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * @deprecated Included for backwards compatibility with JUnit 4.4. Will be | ||
| * removed in the next release. Please use |
There was a problem hiding this comment.
next major release?
ditto in other files
|
Thanks! One suggestion. Might be nice to squash some of those commits, but not a big deal |
|
Fixed the missing "majors". Now squashing... |
This reverts commit 745ca05. The deletion of the classes caused some problems for users (see https://groups.yahoo.com/neo/groups/junit/conversations/topics/24572). In addition, the new coding style has been applied and "major" has been added to the deprecation messages in the Javadoc.
marcphilipp
force-pushed
the
revert-gh862
branch
from
4b78e6b
to
883c1bb
Compare
|
Re-pushed the branch with squashed commits. @kcooney Please take another look. |
kcooney
added a commit
that referenced
this pull request
Sep 12, 2014
Revert "Delete classes that are deprecated for six years."
|
awesome! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 745ca05. The
deletion of the classes causes some problems for users (see
https://groups.yahoo.com/neo/groups/junit/conversations/topics/24572).
This revert is independent from #749. #749 was fixed by 88f7a12.
Since @stefanbirkner seems to be on vacation (are you?) this pull requests continues based on his work in #977.