Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the host application's server connection settings #880

Closed
bollwyvl opened this issue Dec 9, 2022 · 0 comments · Fixed by #882
Closed

Use the host application's server connection settings #880

bollwyvl opened this issue Dec 9, 2022 · 0 comments · Fixed by #882
Labels
env:jupyterlite issues related to browser-based deployment package:jupyterlab-lsp

Comments

@bollwyvl
Copy link
Collaborator

bollwyvl commented Dec 9, 2022

Elevator Pitch

Allow non-JupyterLab applications to override the server connection settings used for fetching status and creating WebSockets.

Motivation

Apps that aren't a full JupyterLab often need to do extra things to serverSettings to communicate (or not) with a server properly.

Specifically, jupyterlite

jupyterlite-lsp (real broken right now) can almost demonstrate providing mock WebSockets, but needs nasty hacks. Unfortunately, even with these hacks, I haven't yet been able to demonstrate one server working due to WebPack issues 😿 .

Design Ideas

  • use serverSettings: app.serverManager.serverSettings in more places
  • hand this down to the connection manager, and use that instead of new WebSocket
bollwyvl added a commit to bollwyvl/jupyterlab-lsp that referenced this issue Dec 11, 2022
bollwyvl added a commit to bollwyvl/jupyterlab-lsp that referenced this issue Dec 11, 2022
@bollwyvl bollwyvl added package:jupyterlab-lsp env:jupyterlite issues related to browser-based deployment labels Dec 12, 2022
krassowski added a commit that referenced this issue Dec 18, 2022
…ings

Use app's HTTP settings, handle feature settings race condition, CI/build updates, lazy server discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:jupyterlite issues related to browser-based deployment package:jupyterlab-lsp
Projects
None yet
1 participant